Privacy Pro Free Trials Core Implementation #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aataraxiaa
force-pushed
the
pete/pp-free-trials-core-implementation
branch
from
d734685 to
b37b625
Compare
|
@federicocappelli, looping you in to be aware of these incoming changes |
miasma13
approved these changes
Jan 10, 2025
Comment on lines
23
to
26
| enum StoreSubscriptionConstants { | ||
| /// The suffix appended to subscription identifiers to indicate that the subscription includes a free trial. | ||
| static let freeTrialSuffix = ".freetrial" | ||
| } |
There was a problem hiding this comment.
Minor comment to that:
- I would drop the
.from the value as it is semantic connector for identifier - It is called a suffix but technically not used as one:
- in l:56-57
.devis appended - elsewhere is checked with
id.contains(StoreSubscriptionConstants.freeTrialSuffix)
There was a problem hiding this comment.
Agree, thanks @miasma13. Have updated based on feedback.
Comment on lines
56
to
57
| "ios.subscription.1month\(StoreSubscriptionConstants.freeTrialSuffix).dev", | ||
| "ios.subscription.1year\(StoreSubscriptionConstants.freeTrialSuffix).dev"], |
There was a problem hiding this comment.
Why the .dev part? Couldn't we reuse the original names and append it with suffix? The multitude of subscriptions is not helpful so sticking to some consistency can be helpful.
There was a problem hiding this comment.
(Chatted with @miasma13 on MM). The staging subscriptions here are not ideally named. However, as the production subs too follow convention, we are ok with leaving this for now.
aataraxiaa
force-pushed
the
pete/pp-free-trials-core-implementation
branch
from
9bac893 to
b02485c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1208767141940868/f
iOS PR: Privacy Pro Free Trials Core Implementation
macOS PR: Privacy Pro Free Trials Core Implementation (BSK Bump Only, No macOS Impacts)
What kind of version bump will this require?: Minor
Tech Design URL: https://app.asana.com/0/1206488453854252/1208916720468103/f
Description: This PR adds additional changes to support Privacy Pro Free Trials on iOS, specifically:
/confirmbackend APISteps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template