Skip to content

Ensure blocklist is updated always #5989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Apr 30, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1202279501986195/task/1210112806879953?focus=true

Description

Remove the eTag checks to ensure blocklist is always stored

Steps to test this PR

Test 1

  • build and install internal debug build
  • launch the app
  • verify Updating the app tracker blocklist, previous/new eTag:... appears in logs

Test 2

  • Change from ExistingPeriodicWorkPolicy.KEEP to ExistingPeriodicWorkPolicy.REPLACE in AppTrackerListUpdateWorkerScheduler
  • build and install internal debug build
  • launch the app
  • verify Updating the app tracker blocklist, previous/new eTag:... appears in logs
  • force close and reopen the app
  • verify Updating the app tracker blocklist, previous/new eTag:... appears in logs

Copy link
Collaborator Author

aitorvs commented Apr 30, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@aitorvs aitorvs marked this pull request as ready for review April 30, 2025 07:41
@laghee
Copy link
Collaborator

laghee commented Apr 30, 2025

@aitorvs I don't get a second update if I force close and re-launch in Test 2 with REPLACE instead of KEEP. Am I missing a step?

Also, interestingly, seems like we're not overwriting the etag, but adding one?
Screenshot 2025-04-30 at 19 50 36

@aitorvs aitorvs force-pushed the fix/aitor/apptp/ensure_update_blocklist branch from 4038d41 to 209f8dc Compare April 30, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants