Fix exception when parsing app-bundled remote config

Author: aitorvs

app-tracking-protection/vpn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/feature/settings/ExceptionListsSettingStore.kt

@@ -50,9 +50,7 @@ class ExceptionListsSettingStore @Inject constructor(
     override fun store(jsonString: String) {
         logcat { "Received configuration: $jsonString" }
         runCatching {
-            jsonAdapter.fromJson(jsonString)?.let { model ->
-
-                val exceptionLists = model.exceptionLists
+            jsonAdapter.fromJson(jsonString)?.exceptionLists?.let { exceptionLists ->
 
                 val appTrackerExceptionRuleList = exceptionLists.appTrackerAllowList.map { appTrackerAllowRule ->
                     AppTrackerExceptionRule(
@@ -78,7 +76,7 @@ class ExceptionListsSettingStore @Inject constructor(
     }
 
     private data class JsonConfigModel(
-        val exceptionLists: JsonExceptionListsModel,
+        val exceptionLists: JsonExceptionListsModel?,
     )
 
     private data class JsonExceptionListsModel(

app-tracking-protection/vpn-impl/src/test/java/com/duckduckgo/mobile/android/vpn/feature/settings/ExceptionListsSettingStoreTest.kt

@@ -96,6 +96,12 @@ class ExceptionListsSettingStoreTest {
 
     @Test
     fun whenEmptyJsonStoreNothing() {
+        exceptionListsSettingStore.store("{}")
+        verifyNoInteractions(mockVpnDatabase)
+    }
+
+    @Test
+    fun whenInvalidJsonStoreNothingAndDoNotCrash() {
         exceptionListsSettingStore.store("")
         verifyNoInteractions(mockVpnDatabase)
     }