-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #2682 Component version lookup #2733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icate code error since script lives in ush
…ns to get formatted version of requested components
…center/metplus-analysis Docker images
…d of build hook file that just adds 6 to major version
This was
linked to
issues
Oct 17, 2024
JohnHalleyGotway
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of these changes.
Checked out this feature branch on seneca and tested this on the command line in several ways.
I note that this also removes `docker/hooks/get_met_version` since that functionality is superseded.
# Show default formatting of vX.Y.Z
> metplus/component_versions.py -i METplus -v 5.1.0 -o MET
v11.1.1
# Define the formatting
> metplus/component_versions.py -i METplus -v 5.1.0 -o MET -f "{X}.{Y}.{Z}"
11.1.1
# Default is for v6.0
> metplus/component_versions.py -o METplotpy
v3.0.0
# Bad inputs report an empty string
> metplus/component_versions.py -i METplus -v 7.0.0 -o MET
# See that develop is returned for vX.Y.Z-dev input
> metplus/component_versions.py -i METplus -v v6.0.0-dev -o MET
develop
I also note that docker/hooks/get_met_version
is removed since it is superseded by these changes.
This was referenced Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the addition of a version lookup table/script to get the version numbers of METplus components, which resolves part of #2562. It also adds a GitHub Actions workflow to build the dtcenter/metplus-analysis Docker image, which resolves #2682.
Pull Request Testing
metplus/component_versions.py
script and tested running script on command line.metplus_component_versions.py
script with various arguments to test functionality (run with-h
to see usage statement). Refer to the unit tests for examples of how the script will be run.Will need to update release guide with information on how to update version lookup table when a bugfix release is created and how to add new entries to the table after an official release (for the next release). I will leave the issue open and make a comment to ensure this is done for the rc1 release.
We will need to keep an eye on the GHA runs for the beta and official releases to ensure everything is working as expected and patch as needed.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by 10/28/2024.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases