Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Add logic to define and parse METplus inter-component version dependencies #2562

Closed
11 of 28 tasks
JohnHalleyGotway opened this issue Apr 24, 2024 · 1 comment · Fixed by #2733 or #2773
Closed
11 of 28 tasks
Assignees
Labels
component: repository maintenance Repository maintenance issue priority: medium Medium Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team type: new feature Make it do something new
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Apr 24, 2024

Describe the New Feature

This topic was discussed during the METplus All Hands meeting on April 24, 2024 and documented in this section of the METplus Engineering meeting notes. Each METplus coordinated release consists of a collection of METplus component releases. The integration testing performed in METplus (for all METplus components) and METviewer (for METplus-Analysis components) needs to know which component versions correspond with each other.

Currently, METplus uses numerical offsets to compute corresponding component version numbers. METplus version X.Y corresponds to:

  • MET version X+6.Y
  • METviewer version X.Y
  • METplotpy version X-3.Y
  • METcalcpy version X-3.Y
  • METdataio version X-3.Y

While this logic does work, it does NOT work for METexpress which releases on a different cycle. And these relationships may break in the future depending on future funding levels. Note also, that this logic is not currently well-implemented for handling METviewer dependencies.

The METplus team decided that it would prefer to move from a numerical offset solution to a table lookup. Recommend adding a Python file to the METplus repo to define a table for all prior METplus coordinated releases along with utility functions to parse that table. Also consider how these version dependencies relate to the manage-externals and avoid duplication of logic as much as possible.

  • Define a table with 7 columns (one each for METplus, MET, METviewer, METplotpy, METcalcpy, METdataio, and METexpress) and 1 row for each prior coordinated release.
  • Define a utility function that...
    • Takes as input a current component and version number.
    • Takes as input a requested METplus component name.
    • Takes as input a requested version "type", such as release version number (e.g. vX.Y.Z), branch name (e.g. main_vX.Y or develop), or DockerHub tag (e.g. MET-11.1-latest).
    • Provides as output the corresponding version name.
  • Many questions remain:
    • How to get the latest bugfix number for the vX.Y release? Perhaps use a vX.Y-latest GitHub tag? And define a GitHub action to auto-update the vX.Y-latest tags?
    • When should develop be returned? And what about beta and rc releases?
    • What about DockerHub image names?
  • Once this functionality exists, update METplus to make use of it.
  • Remember to update the METplus Release Guide to include updating this coordinated release table.
  • Define a METviewer issues to retrieve this table lookup from the METplus develop branch and make good use of it. -- Make use of METplus version lookup script METviewer#554 was created to address this

The goal throughout is avoiding hard-coding METplus component version dependencies and instead define that logic in a single spot.

Acceptance Testing

List input data types and sources.
Describe tests required for new functionality.

Time Estimate

3 days?

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2782544 (NOAA Base)

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added priority: medium Medium Priority type: new feature Make it do something new alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team component: repository maintenance Repository maintenance issue labels Apr 24, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-6.0.0 milestone Apr 24, 2024
@georgemccabe georgemccabe moved this from 🟢 Ready to 🏗 In progress in METplus-Wrappers-6.0.0 Development Oct 15, 2024
@georgemccabe georgemccabe linked a pull request Oct 17, 2024 that will close this issue
16 tasks
@georgemccabe
Copy link
Collaborator

The script and lookup table were added with PR #2733. I am leaving this issue open because I still need to add instructions to update the version numbers to the Release Guide.

georgemccabe added a commit that referenced this issue Nov 5, 2024
…the component versions lookup table in the METplus repository
georgemccabe added a commit that referenced this issue Nov 5, 2024
…ternals to use component version lookup to get versions of METplotpy/METcalcpy/METdataio
@georgemccabe georgemccabe linked a pull request Nov 6, 2024 that will close this issue
16 tasks
@georgemccabe georgemccabe moved this from 🏗 In progress to 🔎 In review in METplus-Wrappers-6.0.0 Development Nov 6, 2024
@jprestop jprestop removed the alert: NEED MORE DEFINITION Not yet actionable, additional definition required label Nov 6, 2024
@georgemccabe georgemccabe changed the title Add logic to define and parse METplus inter-component version dependencies Internal: Add logic to define and parse METplus inter-component version dependencies Nov 6, 2024
@michelleharrold michelleharrold added reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Nov 6, 2024
jprestop added a commit that referenced this issue Nov 7, 2024
* set default input version to the latest official release, which is the 2nd highest coordinated release version number in the version lookup table. This assumes that the highest version is what is being developed towards

* per #2562, update Release Guide to include instructions for updating the component versions lookup table in the METplus repository

* Per #2562 and #2597, replace automated test logic that used manage_externals to use component version lookup to get versions of METplotpy/METcalcpy/METdataio

* clean up SonarQube complaints

* turn on some use cases to test changes

* fix clone

* do not get python dependencies for METplotpy/METcalcpy/METdataio installs

* use full path to package to import

* clone METplus Analysis repos on the same level as METplus to match previous location using manage_externals, remove manage_externals config files that are no longer used by the automated tests

* clean up linter complaints

* turn off use cases after confirming that they run successfully

* clean up usage statement formatting

* remove info about updating manage_externals config files used in automated tests that have been removed

* added description of component versions script to Contributor's Guide and added stubs for other utility descriptions

* change format of example results and add text to describe what is being demonstrated from each example

* fix formatting

* fixed bad variable replacement

* Update docs/Contributors_Guide/utilities.rst

---------

Co-authored-by: Julie Prestopnik <[email protected]>
@jprestop jprestop closed this as completed Nov 7, 2024
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-Wrappers-6.0.0 Development Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: repository maintenance Repository maintenance issue priority: medium Medium Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team type: new feature Make it do something new
Projects
Status: 🏁 Done
4 participants