[#103] Update logic to get twitter username

[JNicolao]

Make sure the checklist below is checked before PR merge, mark if not applicable

PR Checklist

• [-] UI created matched design
• [-] For evey color class added, dark: is defined, images have alt and _blank links have rel
• [-] API is integrated as required
• [-] Page is responsive

What is the Purpose?

To update logic to get twitter username from both domains

Briefly describe what the PR addresses
[#103]

What was the approach?

check if the URL contains either twitter.com or x.com. split the string to extract the username based on which domain is present.

Are there any concerns to addressed further before or after merging this PR?

No

State some additional info if any. For instance running install or setting some environment variable(s)

Mentions?

Mention persons you'd like to review this PR
@manuelgeek

Issue(s) affected?

List of issues addressed by this PR.
#103

[danielotieno]

What does the function return? string, null or both? const getTwitterUsername = (url: string): string | null

if it's not url, you can return null form the start

if (!url) return null;

You can use regex to match both twitter and x URLs

const match = url.match(/(?:twitter\.com|x\.com)\/([^/?#]+)/i);
return match?.[1] ?? null;

The complete function

const getTwitterUsername = (url: string): string | null => {
  if (!url) return null;
  
  const match = url.match(/(?:twitter\.com|x\.com)\/([^/?#]+)/i);
  return match?.[1] ?? null;
}

[JNicolao]

This is fantastic @danielotieno . I don't know how I missed that. Exiting the loop early for non URLs will remove unnecessary processing. Let me make the changes.

[danielotieno]

Here, why not?

{getTwitterUsername(speaker.twitter) ?? speaker.name}

[JNicolao]

Thanks @danielotieno . Let me implement that. What do you think about
{getTwitterUsername(speaker.twitter ?? '') ?? speaker.name} to ensure that speaker.twitter is a string before passing it to getTwitterUsername ?

[manuelgeek]

{getTwitterUsername(speaker.twitter ?? '') || speaker.name}
you can check the usage of || vs ??

[danielotieno]

Or if you want to use ternary

{speaker.twitter 
  ? getTwitterUsername(speaker.twitter) || speaker.name
  : speaker.name}

[JNicolao]

Yes || would be best in this case. I've already resolved this and pushed. Please review.