Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#103] Update logic to get twitter username in SpeakerDetail component #105

Closed
wants to merge 1 commit into from

Conversation

JNicolao
Copy link
Collaborator

Make sure the checklist below is checked before PR merge, mark if not applicable

PR Checklist

  • [.] UI created matched design
  • [.] For evey color class added, dark: is defined, images have alt and _blank links have rel
  • [.] API is integrated as required
  • [.] Page is responsive

What is the Purpose?

To update logic to get twitter username from both domains x.com and twitter.com

What was the approach?

check if the URL contains either twitter.com or x.com. split the string to extract the username based on which domain is present.

Are there any concerns to addressed further before or after merging this PR?

No

Mentions?

@manuelgeek

Issue(s) affected?

#103

@manuelgeek
Copy link
Member

@JNicolao this is duplicate of #104

@manuelgeek manuelgeek closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants