Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): formula dependency #4224

Merged
merged 6 commits into from
Dec 6, 2024
Merged

fix(formula): formula dependency #4224

merged 6 commits into from
Dec 6, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Dec 4, 2024

close https://github.com/dream-num/univer-pro/issues/3539

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 4, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer force-pushed the fix-formula-dependency branch from aad8286 to ee943ad Compare December 4, 2024 06:57
@DR-Univer DR-Univer marked this pull request as ready for review December 4, 2024 06:58
Copy link

github-actions bot commented Dec 4, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 50 seconds
commit  101ff12
info  For more information, see full report

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 4, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 6, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 6, 2024
@oumomomo oumomomo removed the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 6, 2024
@oumomomo
Copy link

oumomomo commented Dec 6, 2024

另外一个pr也有以下问题,待润泽确认#4198

场景1、选中单元格后切换表编辑,输入的内容没有展示在当前表
1、在表1选中某单元格后
2、切换至表2不点击任何单元格直接编辑,编辑内容会展示在表1

预期表现:编辑内容展示在表1,且展示的单元格正确
2024_12_6 11_06_42 video.webm

场景2、刷新页面后不点击单元格,无法直接编辑
image

@univer-bot
Copy link

univer-bot bot commented Dec 6, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Another PR also has the following problems, to be confirmed by Runze #4198

Scenario 1. After selecting a cell and switching table editing, the entered content is not displayed in the current table.

  1. After selecting a cell in Table 1
  2. Switch to Table 2 and edit directly without clicking any cells. The edited content will be displayed in Table 1.

Expected performance: The edited content is displayed in Table 1, and the displayed cells are correct.
2024_12_6 11_06_42 video.webm

Scenario 2: After refreshing the page, you cannot directly edit the cell without clicking on it.
image

@oumomomo oumomomo mentioned this pull request Dec 6, 2024
4 tasks
@Dushusir
Copy link
Member

Dushusir commented Dec 6, 2024

另外一个pr也有以下问题,待润泽确认#4198

场景1、选中单元格后切换表编辑,输入的内容没有展示在当前表 1、在表1选中某单元格后 2、切换至表2不点击任何单元格直接编辑,编辑内容会展示在表1

预期表现:编辑内容展示在表1,且展示的单元格正确 2024_12_6 11_06_42 video.webm

场景2、刷新页面后不点击单元格,无法直接编辑 image

可能与 #4226 有关,rebase dev 后再复测下 @DR-Univer @oumomomo

@univer-bot
Copy link

univer-bot bot commented Dec 6, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Another PR also has the following problem, to be confirmed by Runze #4198

Scenario 1. After selecting a cell and switching to table editing, the entered content is not displayed in the current table. 1. After selecting a cell in Table 1. 2. Switching to Table 2 to edit directly without clicking any cells. The edited content will be displayed in the table. 1

Expected performance: The edited content is displayed in Table 1, and the displayed cells are correct 2024_12_6 11_06_42 video.webm

Scenario 2: After refreshing the page, you cannot directly edit the cell without clicking on it. ![image](https://private-user-images.githubusercontent.com/167171356/393078795-b5c1db06-a8c0-42ff- abf2-63540fc296af.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoi cmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzM0NzI1NzQsIm5iZiI6MTczMzQ3MjI3NCw icGF0aCI6Ii8xNjcxNzEzNTYvMzkzMDc4Nzk1LWI1YzFkYjA2LWE4YzAtNDJmZi1hYmYyLTYzNTQwZmMyOTZhZi5wbmc_WC1BbX otQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQx MjA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTIwNlQwODA0MzRaJlgtQW16LUV4cGl yZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01MGIzMWZiMGVhZDBiZjA0NTg1OTgwNDhjOTk3MDc4YzdmY2RhYWNiMjM4NTkzYzNjNT cxNWYyZDM3NTE3NTZiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.gYmwyufPUrSqUJfWmcIiFBHLXWHvjDMR03TiehIMDUc)

It may be related to #4226, rebase dev and then retest @DR-Univer @oumomomo

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 6, 2024
@univer-bot univer-bot bot removed the qa:rejected label Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.66%. Comparing base (b653da5) to head (101ff12).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
...kages/engine-formula/src/engine/analysis/parser.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4224      +/-   ##
==========================================
- Coverage   33.68%   33.66%   -0.03%     
==========================================
  Files        2490     2496       +6     
  Lines      128060   128127      +67     
  Branches    28710    28723      +13     
==========================================
- Hits        43142    43138       -4     
- Misses      84918    84989      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit 6dd4b16 into dev Dec 6, 2024
9 checks passed
@DR-Univer DR-Univer deleted the fix-formula-dependency branch December 6, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants