Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): sheet name quote #4198

Merged
merged 15 commits into from
Jan 7, 2025
Merged

fix(sheet): sheet name quote #4198

merged 15 commits into from
Jan 7, 2025

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Nov 30, 2024

close #1898
close #1986 (No code update, just retest)
close #2186 (No code update, just retest)
close #1190

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 30, 2024

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 14 seconds
commit  d8ae941
info  For more information, see full report

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 12.90323% with 81 lines in your changes missing coverage. Please review.

Project coverage is 32.67%. Comparing base (2ec2c5e) to head (d8ae941).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
.../src/controllers/numfmt-alert-render.controller.ts 0.00% 53 Missing ⚠️
...ontrollers/force-string-alert-render.controller.ts 0.00% 10 Missing ⚠️
packages/sheets-numfmt-ui/src/plugin.ts 0.00% 7 Missing ⚠️
...-formula/src/engine/analysis/lexer-tree-builder.ts 0.00% 6 Missing ⚠️
.../src/controllers/numfmt-cell-content.controller.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4198      +/-   ##
==========================================
- Coverage   32.77%   32.67%   -0.10%     
==========================================
  Files        2561     2568       +7     
  Lines      132929   133349     +420     
  Branches    29600    29674      +74     
==========================================
+ Hits        43568    43573       +5     
- Misses      89361    89776     +415     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the dushusir/formula-bugs1130 branch from f94d061 to 2e66dc0 Compare December 2, 2024 03:03
@Dushusir Dushusir marked this pull request as ready for review December 2, 2024 03:07
@Dushusir Dushusir requested a review from wzhudev as a code owner December 2, 2024 03:07
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 2, 2024
@oumomomo
Copy link

oumomomo commented Dec 2, 2024

https://github.com/dream-num/univer-pro/issues/1898

将表1&表2的名字均加上单引号,在表3内单元格输入=引用表1&表2的区域,计算时页面会先卡死
2024_12_2 15_31_48 video.webm

@univer-bot
Copy link

univer-bot bot commented Dec 2, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://github.com/dream-num/univer-pro/issues/1898

Add single quotes to the names of Table 1 & Table 2, and enter = in the cell of Table 3 to reference the area of ​​Table 1 & Table 2. The page will freeze first during calculation.
2024_12_2 15_31_48 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 2, 2024
@Dushusir Dushusir requested a review from Gggpound as a code owner December 3, 2024 10:01
@Dushusir Dushusir force-pushed the dushusir/formula-bugs1130 branch from d698210 to 22e637a Compare December 3, 2024 10:01
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Dec 3, 2024
@univer-bot univer-bot bot removed the qa:rejected label Dec 3, 2024
@Dushusir Dushusir force-pushed the dushusir/formula-bugs1130 branch from 4225bee to c532ea7 Compare December 3, 2024 12:50
@Dushusir Dushusir requested a review from VicKun4937 as a code owner December 4, 2024 04:16
@oumomomo
Copy link

oumomomo commented Dec 6, 2024

#4224
跟其他pr单里有相同问题,待确定

@univer-bot
Copy link

univer-bot bot commented Dec 6, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

#4224
I have the same problem as other pr orders, to be determined

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 6, 2024
@oumomomo oumomomo mentioned this pull request Dec 6, 2024
4 tasks
@Dushusir Dushusir force-pushed the dushusir/formula-bugs1130 branch from 642b49e to 855489d Compare December 6, 2024 08:04
@Dushusir
Copy link
Member Author

Dushusir commented Dec 6, 2024

#4224 跟其他pr单里有相同问题,待确定

可能与 #4226 有关,dev已经恢复,已 rebase dev

@univer-bot
Copy link

univer-bot bot commented Dec 6, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

#4224 has the same problem as other pr orders, to be determined

It may be related to #4226, dev has been restored and rebase dev

@DR-Univer
Copy link
Collaborator

dream-num/univer-pro#1898

将表1&表2的名字均加上单引号,在表3内单元格输入=引用表1&表2的区域,计算时页面会先卡死 2024_12_2 15_31_48 video.webm

@Dushusir 跟进下,和选区绘制时机相关。

@univer-bot
Copy link

univer-bot bot commented Dec 6, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

dream-num/univer-pro#1898

Add single quotes to the names of Table 1 & Table 2, and enter = in the cell in Table 3 to reference the area of ​​Table 1 & Table 2. The page will freeze first during calculation [2024_12_2 15_31_48 video.webm](https://github .com/user-attachments/assets/0ae1c33c-b771-4901-b6d7-18c0f3c9a25f)

fixed

@Dushusir
Copy link
Member Author

Dushusir commented Dec 6, 2024

dream-num/univer-pro#1898
将表1&表2的名字均加上单引号,在表3内单元格输入=引用表1&表2的区域,计算时页面会先卡死 2024_12_2 15_31_48 video.webm

@Dushusir 跟进下,和选区绘制时机相关。

已知有单引号存储和回显问题,目前已经修复

@univer-bot
Copy link

univer-bot bot commented Dec 6, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

dream-num/univer-pro#1898
Add single quotes to the names of Table 1 & Table 2, and enter = in the cell in Table 3 to reference the area of ​​Table 1 & Table 2. The page will freeze first during calculation [2024_12_2 15_31_48 video.webm](https:// github.com/user-attachments/assets/0ae1c33c-b771-4901-b6d7-18c0f3c9a25f)

@Dushusir Follow up, it is related to the timing of selection drawing.

There are known issues with single quote storage and echoing, which have been fixed.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 6, 2024
@univer-bot univer-bot bot removed the qa:rejected label Dec 6, 2024
@Dushusir Dushusir requested a review from siam-ese as a code owner January 7, 2025 04:16
@Dushusir Dushusir force-pushed the dushusir/formula-bugs1130 branch from 8555959 to b5fb11c Compare January 7, 2025 04:20
@Dushusir Dushusir merged commit f42c01a into dev Jan 7, 2025
9 checks passed
@Dushusir Dushusir deleted the dushusir/formula-bugs1130 branch January 7, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants