Skip to content

release/7.0 staging #89904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 872 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
872 commits
Select commit Hold shift + click to select a range
9f9cb22
Merge in 'release/7.0' changes
dotnet-bot Feb 11, 2023
d05bbe4
[release/7.0] Prevent unwinding through stack bottom (#81804)
github-actions[bot] Feb 13, 2023
f3c7837
Merge in 'release/7.0' changes
dotnet-bot Feb 13, 2023
9d02343
Fix XmlSqlBinaryReader and introduce a corpus of SqlXml tests (#81878…
jeffhandley Feb 14, 2023
dcb489a
Merge in 'release/7.0' changes
dotnet-bot Feb 14, 2023
bd47178
Merge commit '0a2bda10e81d901396c3cff95533529e3a93ad47' into internal…
vseanreesermsft Feb 14, 2023
a9b6c14
add RID for Ubuntu 23.04 (#82123)
wfurt Feb 15, 2023
527278b
Merge pull request #82117 from vseanreesermsft/internal-merge-7.0-202…
carlossanlop Feb 15, 2023
cc8752f
Merge in 'release/7.0' changes
dotnet-bot Feb 15, 2023
b68fd88
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] Feb 15, 2023
0a396ac
Merge in 'release/7.0' changes
dotnet-bot Feb 16, 2023
94213eb
Update branding to 7.0.5 (#83103)
wtgodbe Mar 8, 2023
2bc9b0a
[7.0] Fix superpmi_collect-setup.py helix images to use floating vers…
carlossanlop Mar 8, 2023
5a76ad1
Merge in 'release/7.0' changes
dotnet-bot Mar 8, 2023
84e7e19
Merge in 'release/7.0' changes
dotnet-bot Mar 8, 2023
dcf014d
[release/7.0] Update dependencies from dotnet/llvm-project dotnet/run…
dotnet-maestro[bot] Mar 8, 2023
b0f1bb4
Update dependencies from https://github.com/dotnet/icu build 20230215…
dotnet-maestro[bot] Mar 8, 2023
b76fdb9
Install native dependencies on all Apple OS in CI (#82323)
am11 Mar 8, 2023
2c2402c
Merge in 'release/7.0' changes
dotnet-bot Mar 8, 2023
2c4c237
Microsoft.NETCore.Platforms: fix graph not being updated on pack. (#8…
github-actions[bot] Mar 8, 2023
7e25da6
Merge in 'release/7.0' changes
dotnet-bot Mar 8, 2023
8a7a2ea
[release/7.0][workloads] Backport UsingMobileWorkload change (#82268)
steveisok Mar 8, 2023
60d5c56
[wasm] Use latest sdk 7.0 sdk for workload testing, and perf runs (#8…
radical Mar 8, 2023
882512d
Merge in 'release/7.0' changes
dotnet-bot Mar 8, 2023
d46f5e5
Merge in 'release/7.0' changes
dotnet-bot Mar 8, 2023
a03dfad
[release/7.0] System.Console: allow terminfo files to be larger than …
github-actions[bot] Mar 8, 2023
b524e93
[release/7.0] [browser] fix asset counting after download retry (#82617)
pavelsavara Mar 8, 2023
a1a6ef3
Merge in 'release/7.0' changes
dotnet-bot Mar 8, 2023
dbb333c
Add NT_SIGINFO NOTE to ELF dumps (#83059)
Mar 8, 2023
43b0192
Fix pthread_cond_wait race on macOS (#82893)
github-actions[bot] Mar 8, 2023
089ea99
Merge in 'release/7.0' changes
dotnet-bot Mar 8, 2023
24fd641
[7.0] Check for pending IO in the portable thread pool's worker threa…
kouvel Mar 9, 2023
3bfe479
[release/7.0] Fix disposing root X.509 certificate prematurely for OC…
github-actions[bot] Mar 9, 2023
0e0edcd
Console.Unix: fix escape sequence for setting title on 'screen' TERM.…
github-actions[bot] Mar 9, 2023
323bdf3
[7.0] Fix intellisense xml file selection from 'net' or 'dotnet-plat-…
carlossanlop Mar 9, 2023
2f81831
Merge in 'release/7.0' changes
dotnet-bot Mar 9, 2023
d7aa584
[release/7.0] Add a RID for Fedora 39 (#82208)
omajid Mar 9, 2023
2486cb8
Backport PR #82480 to 7.0 (#82572)
kg Mar 9, 2023
cd2e0a6
backport of 82852 (#82854)
thaystg Mar 9, 2023
ac81828
[release/7.0] Port #82470 (disable EventPipe stack collection with en…
davmason Mar 9, 2023
6eaaf26
[release/7.0] Add more type-forwarders for Xamarin.Android compatibil…
akoeplinger Mar 9, 2023
21bd0a7
Merge in 'release/7.0' changes
dotnet-bot Mar 9, 2023
6e6eab2
[release/7.0] Fix thread-safety issues with enumerating ResourceManag…
github-actions[bot] Mar 10, 2023
15f5d02
Merge in 'release/7.0' changes
dotnet-bot Mar 10, 2023
01a25fa
Do not use ALC name for AssemblyName (#82754) (#82807)
buyaa-n Mar 10, 2023
0f05efe
Merge in 'release/7.0' changes
dotnet-bot Mar 10, 2023
170dd10
Add tar tests to confirm entries owned by deleted users can still be …
carlossanlop Mar 10, 2023
eaaed2a
Merge in 'release/7.0' changes
dotnet-bot Mar 10, 2023
5a1baeb
Merged PR 29231: [internal/release/7.0] Fix handling of load for msqu…
elinor-fung Mar 10, 2023
5b74781
[release/7.0] Fix PAX extended attribute reading logic to treat '=' c…
github-actions[bot] Mar 10, 2023
2448ea9
prevent use of null when processing alpn list (#81797)
github-actions[bot] Mar 10, 2023
5359e8e
Merge in 'release/7.0' changes
dotnet-bot Mar 10, 2023
ca584ef
Update usage of AllowEmptyTelemetry based on changes to the task in t…
github-actions[bot] Mar 11, 2023
bfdc43b
Merge in 'release/7.0' changes
dotnet-bot Mar 11, 2023
2a0783a
[release/7.0] Update dependencies from dotnet/emsdk (#82192)
dotnet-maestro[bot] Mar 13, 2023
53455cc
[release/7.0] Update emsdk (#83244)
lewing Mar 14, 2023
56da0d3
Fix address data emitted in the MonoProfilerGCRoots ETW event (#83327)
github-actions[bot] Mar 14, 2023
71aa107
Merge in 'release/7.0' changes
dotnet-bot Mar 14, 2023
b77565a
Merge commit '0a396acafe9a7d46bce11f4338dbb3dd0d99b1b4' into internal…
vseanreesermsft Mar 14, 2023
1377e5e
Merge pull request #83405 from vseanreesermsft/internal-merge-7.0-202…
carlossanlop Mar 14, 2023
634640c
Merge in 'release/7.0' changes
dotnet-bot Mar 14, 2023
1e9466d
[release/7.0] Update dependencies from dotnet/arcade (#83467)
dotnet-maestro[bot] Mar 15, 2023
2c9e64f
Merge in 'release/7.0' changes
dotnet-bot Mar 15, 2023
90461a2
[release/7.0] Fix System.Management wminet_utils.dll lookup code for …
github-actions[bot] Mar 17, 2023
90e3df4
Merge in 'release/7.0' changes
dotnet-bot Mar 17, 2023
3286b32
Update dependencies from https://github.com/dotnet/emsdk build 202303…
dotnet-maestro[bot] Mar 20, 2023
fb541ff
Merge in 'release/7.0' changes
dotnet-bot Mar 20, 2023
6a533c1
Update dependencies from https://github.com/dotnet/emsdk build 202303…
dotnet-maestro[bot] Mar 23, 2023
8042d61
Merge in 'release/7.0' changes
dotnet-bot Mar 23, 2023
f5b9cd4
[7.0] Update backport template and servicing docs (#84005)
carlossanlop Mar 28, 2023
57d635b
Create action to check servicing label (#84041)
github-actions[bot] Mar 28, 2023
7786569
Fix piping in yml (#84042)
hoyosjs Mar 28, 2023
4c367c7
Update check-service-labels.yml (#84044)
hoyosjs Mar 28, 2023
8c9da40
[7.0] Avoid using spanish helix queues (#83747)
carlossanlop Mar 28, 2023
80d48e9
[release/7.0] Bump to new OSX 13 AppleTV queue (#83729)
steveisok Mar 29, 2023
74d0f47
[release/7.0] disable NTLM tests on RedHat.7 (#83602)
github-actions[bot] Mar 29, 2023
fb993f5
[release/7.0] Improve servicing docs for Microsoft.Windows.Compatibil…
carlossanlop Mar 29, 2023
1cee763
Fix Iran time zone test case (#84056)
carlossanlop Mar 29, 2023
721e656
Update check-service-labels to trigger on branch edit (#84106)
hoyosjs Mar 30, 2023
05038f9
[release/7.0][mono] Use unsigned char when computing UTF8 string hash…
lambdageek Mar 30, 2023
88b65f9
Ensure that default media type is used when 'null' is passed-in to St…
github-actions[bot] Mar 30, 2023
8d12002
Updated MS.DiaSymReader.Native to 16.11.27-beta1.23180.1
hoyosjs Mar 31, 2023
641393e
[release/7.0] [wasm] ManagedToNativeGenerator: Skip unmanaged dlls (#…
github-actions[bot] Mar 31, 2023
fa133ae
[release/7.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#675…
simonrozsival Mar 31, 2023
7cd68bc
[release/7.0] JIT: fix bug in cloning conditions for jagged array (#8…
AndyAyersMS Mar 31, 2023
001172f
[release/7.0] Ensure free buffer space when reading TLS messages (#83…
github-actions[bot] Apr 3, 2023
5301032
[release/7.0] SyntaxValueProvider: avoid performance issue with synta…
github-actions[bot] Apr 4, 2023
f8777ff
Fixing a bug that causes us to mistakenly demote a gen2 region to gen…
github-actions[bot] Apr 4, 2023
ed90f14
Fix special sweep issue for workstation (#83342)
github-actions[bot] Apr 4, 2023
c367508
[7.0] Add check-service-labels.yml to unblock base branch PRs (#84331)
carlossanlop Apr 5, 2023
ee07b3e
Update branding to 7.0.6 (#84316)
vseanreesermsft Apr 5, 2023
6edec23
Merge in 'release/7.0' changes
dotnet-bot Apr 5, 2023
eacc9be
[release/7.0] Fix encoding problem when publishing (#83577)
ilonatommy Apr 5, 2023
4a5620b
[release/7.0] [MONO][MARSHAL] Initialize ilgen with a flag (#83813)
github-actions[bot] Apr 5, 2023
0506145
[release/7.0-staging] Update dependencies from dotnet/linker dotnet/m…
dotnet-maestro[bot] Apr 6, 2023
30d3c9c
Update dependencies from https://github.com/dotnet/emsdk build 202304…
dotnet-maestro[bot] Apr 6, 2023
f5f7b34
Merge in 'release/7.0' changes
dotnet-bot Apr 6, 2023
c2d6594
[release/7.0] Fix pinned assembly version 7.0 (#84355)
ericstj Apr 6, 2023
694c2a0
Merge branch 'release/7.0-staging' into release70
carlossanlop Apr 7, 2023
cb70e92
Manually resolve spacing conflict in check-service-labels.yml
carlossanlop Apr 7, 2023
d71dd07
Merge branch 'release70' of github.com:carlossanlop/runtime into rele…
carlossanlop Apr 7, 2023
48abc27
Merge pull request #84459 from carlossanlop/release70
carlossanlop Apr 7, 2023
062f700
[release/7.0] Update dependencies from dotnet/runtime-assets (#84123)
dotnet-maestro[bot] Apr 7, 2023
0fddbf9
Merge in 'release/7.0' changes
dotnet-bot Apr 7, 2023
7e8c33e
Reverting: Set AssemblyName.ProcessorArchitecture for compatibility. …
VSadov Apr 7, 2023
08e0f70
CVE-2023-24936: Check type is allowed when deserializing insatance ty…
ajcvickers Mar 16, 2023
33b8556
Merged PR 30054: Check type is allowed when deserializing insatance t…
ajcvickers Apr 7, 2023
50722b0
[release/7.0] Fix reserving executable memory as per allocation type …
github-actions[bot] Apr 10, 2023
45cad1d
Updated MS.DiaSymReader.Native to 16.11.27-beta1.23180.1
hoyosjs Apr 10, 2023
8a0b03e
[release/7.0][Android] Free up more disk space on CI builds (#84567)
steveisok Apr 10, 2023
3947f8d
Update dependencies from https://github.com/dotnet/linker build 20230…
dotnet-maestro[bot] Apr 10, 2023
d566ecf
[7.0] Reset OOB packages from 7.0.5 (#84341)
carlossanlop Apr 11, 2023
a283bb9
Merge pull request #84594 from carlossanlop/release/7.0-staging
carlossanlop Apr 11, 2023
b402106
[7.0-staging] Bump branding to 7.0.7 (#84597)
carlossanlop Apr 11, 2023
0b43eeb
Merge in 'release/7.0' changes
dotnet-bot Apr 11, 2023
4e9cde7
Merge commit '8042d61b17540e49e53569e3728d2faa1c596583' into internal…
vseanreesermsft Apr 11, 2023
af23cd6
Merge pull request #84640 from vseanreesermsft/internal-merge-7.0-202…
carlossanlop Apr 11, 2023
5f1ec97
Merge in 'release/7.0' changes
dotnet-bot Apr 11, 2023
d477fbf
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] Apr 12, 2023
41b6f22
Merge in 'release/7.0' changes
dotnet-bot Apr 12, 2023
2165458
[release/7.0-staging] Update dependencies from dotnet/arcade dotnet/l…
dotnet-maestro[bot] Apr 12, 2023
5266169
Update dependencies from https://github.com/dotnet/icu build 20230411…
dotnet-maestro[bot] Apr 12, 2023
43b5822
Update dependencies from https://github.com/dotnet/emsdk build 202304…
dotnet-maestro[bot] Apr 12, 2023
e3acf02
Merge in 'release/7.0' changes
dotnet-bot Apr 12, 2023
70c91e2
Fix AwaitableSocketAsyncEventArgs reorderings on weaker memory models…
github-actions[bot] Apr 14, 2023
3de70ef
[release/7.0] Move mono.mscordbi subset off the offical buildMove mon…
steveisok Apr 17, 2023
2a25ee7
Merge in 'release/7.0' changes
dotnet-bot Apr 17, 2023
bc4b1f2
Merge pull request #84611 from dotnet-maestro-bot/merge/release/7.0-t…
carlossanlop Apr 19, 2023
6e3c5c7
Backport #78136 to .NET 7 (#84936)
jkoritzinsky Apr 21, 2023
0418529
Change loading sequence for Windows PDB parsing
hoyosjs Apr 20, 2023
b3793a9
Update dependencies from https://github.com/dotnet/icu build 20230418…
dotnet-maestro[bot] Apr 24, 2023
91c7793
Skip DllImportSearchPathsTest on wasm (#84735)
elinor-fung Apr 24, 2023
f61192d
[PERF] Remove pipeline dependencies and steps for running Maui Mobile…
LoopedBard3 Apr 24, 2023
7aa3f0c
Backport PR#77480 to 7.0. (#85309)
PeterSolMS Apr 25, 2023
f16c731
Add metadata update for overrides (#85259)
fanyang-mono Apr 26, 2023
fbd8c18
Caching settings.pause_mode to avoid deadlock (#84738)
github-actions[bot] Apr 26, 2023
86ce6a1
[release/7.0-staging] Update dependencies from dotnet/hotreload-utils…
dotnet-maestro[bot] Apr 27, 2023
06e5b35
[native-library] If a dllimport is specified with an absolute path, l…
github-actions[bot] Apr 27, 2023
3a80b29
Added the ability to specify a Spin Count Unit via a GC Configuration…
mrsharm Apr 27, 2023
12aaae4
Fix createdump arg parsing for signal-based exceptions (#85423)
github-actions[bot] Apr 28, 2023
693a3c6
define UNW_AARCH64 aliases conditionally (#84874)
VSadov May 3, 2023
cbeb728
Update branding to 7.0.7 (#85670)
vseanreesermsft May 3, 2023
d689f47
Merge in 'release/7.0' changes
dotnet-bot May 3, 2023
98528ec
Merge pull request #85719 from dotnet-maestro-bot/merge/release/7.0-t…
carlossanlop May 3, 2023
ad24dac
Update dependencies from https://github.com/dotnet/icu build 20230418…
dotnet-maestro[bot] May 3, 2023
7416d98
Add missing TarFile.CreateFromDirectoryAsync roundtrip tests. (#84856)
github-actions[bot] May 3, 2023
806235b
Tar: Ensure trailing separator in sanitized path for extraction
carlossanlop May 3, 2023
1746b88
Merge in 'release/7.0' changes
dotnet-bot May 3, 2023
17d84d7
Add status code and exception info to System.Net.Http events (#84806)
MihaZupan May 3, 2023
47f52f1
[release/7.0-staging] Update dependencies from xharness, arcade (#85726)
dotnet-maestro[bot] May 4, 2023
c8ab0d3
[release/7.0-staging] Make WindowsServiceLifetime gracefully stop (#8…
ericstj May 4, 2023
5b71fde
Servicing docs improvements (#85731)
carlossanlop May 6, 2023
cd73b4f
Port perfmap work to 7 (#85072)
davmason May 8, 2023
921628f
Merged PR 30131: Only clean up elements that have been marshalled in …
jtschuster May 8, 2023
bf47f0d
[Release/7.0] Port EventCounters multi session support to 7.0 (#84679)
davmason May 11, 2023
2b28c92
[release/7.0-staging] [browser] fix job queue timespan calculation (#…
github-actions[bot] May 12, 2023
e005374
Fix HTTP3 header decoder buffer allocation (#78862) (#85977)
ManickaP May 15, 2023
d1506cd
Update dependencies from https://github.com/dotnet/emsdk build 202305…
dotnet-maestro[bot] May 15, 2023
fb0bf59
Update dependencies from https://github.com/dotnet/emsdk build 202305…
dotnet-maestro[bot] May 15, 2023
eb0d56e
Merge in 'release/7.0' changes
dotnet-bot May 15, 2023
bf7c094
Add linker flags to add fixup data to PDBs (#58417) (#84358)
github-actions[bot] May 15, 2023
6f9d91c
[release/7.0] Suppress clang-16 warnings (backport #81573) (#84444)
ayakael May 15, 2023
edef3b9
[release/7.0-staging] Microsoft.NETCore.Platforms: support adding rid…
github-actions[bot] May 16, 2023
b4a441a
add RID for Alpine 3.18 (#86280)
github-actions[bot] May 16, 2023
eb3160d
Add Ubuntu 22.10 kinetic kudu RIDs for .NET 7 (#84984)
dviererbe May 16, 2023
1182123
[7.0-staging] Reset OOB packages from 7.0.6 (#84600)
carlossanlop May 16, 2023
7d21bfd
Merged PR 31140: [release/7.0] Add delay load hook for singlefilehost…
elinor-fung May 16, 2023
92f8090
Add Ubuntu 23.10 (Mantic Minotaur) RIDs to .NET 7 (#86306)
dviererbe May 16, 2023
a2fd545
Merge branch 'release/7.0' into release/7.0-staging
carlossanlop May 16, 2023
751fa8b
Revert "[7.0-staging] Reset OOB packages from 7.0.6 (#84600)"
carlossanlop May 16, 2023
7c002df
Merge pull request #86296 from carlossanlop/release/7.0-staging
carlossanlop May 16, 2023
42eaa40
Revert "[7.0-staging] Reset OOB packages from 7.0.6 (#84600)" (#86352)
carlossanlop May 16, 2023
c5ef99c
Bump branding to 7.0.8 (#86297)
carlossanlop May 16, 2023
4906b56
[release/7.0] Only use shipped version of symreader
hoyosjs May 18, 2023
a12825a
Merge pull request #86359 from dotnet-maestro-bot/merge/release/7.0-t…
carlossanlop May 18, 2023
8e3442d
Merged PR 31292: [7.0] Apply iteration work limits to X509 certificat…
krwq May 19, 2023
2a63c9d
[release/7.0] Ensure that the shuffle zero mask copies all bits (#86453)
tannergooding May 22, 2023
8a90f22
[7.0] Missing version bump number (#86599)
carlossanlop May 23, 2023
417a015
[7.0] Remove centos 8 images (#86477)
carlossanlop May 23, 2023
051ae7d
[release/7.0] Move to new osx test queue for ios devices (#86647)
steveisok May 23, 2023
5b20af4
Merged PR 31513: [internal/release/7.0] Merge from public
mmitche May 24, 2023
1e155e1
[7.0] Disable DllImportSearchPathsTest in mobile (#86708)
akoeplinger May 26, 2023
527cd69
[release/7.0-staging][mono][debugger] Remove cast bug (#86862)
ilonatommy Jun 6, 2023
0db8a39
Update branding to 7.0.8 (#87192)
vseanreesermsft Jun 7, 2023
6473c63
Merge in 'release/7.0' changes
dotnet-bot Jun 7, 2023
079e9e8
[release/7.0-staging] [mono] Use underlying type in RuntimeHelpers.Ge…
github-actions[bot] Jun 7, 2023
0f871c5
Update dependencies from https://github.com/dotnet/emsdk build 202306…
dotnet-maestro[bot] Jun 8, 2023
5c873bd
Update dependencies from https://github.com/dotnet/emsdk build 202306…
dotnet-maestro[bot] Jun 8, 2023
750f9a1
Merge in 'release/7.0' changes
dotnet-bot Jun 8, 2023
afb41da
[release/7.0-staging] [mono][aot] Generate 'native-indirect' wrappers…
github-actions[bot] Jun 9, 2023
4d2768a
[release/7.0-staging] Fix creating cultures with extensions in the na…
github-actions[bot] Jun 10, 2023
f39e05a
[release/7.0] Change NamedPipe creation flags
hoyosjs Jun 12, 2023
e13041e
Merge pull request #86617 from dotnet-maestro-bot/merge/release/7.0-t…
carlossanlop Jun 12, 2023
27dd02f
[Release/7.0][PERF] Backport urllib fix to release/7.0 (#87286)
LoopedBard3 Jun 12, 2023
c40f850
[release/7.0-staging] Fix neutral cultures created with the underscor…
tarekgh Jun 12, 2023
329c722
add RID for Debian 12 (#87441)
github-actions[bot] Jun 13, 2023
ff02a1f
[release/7.0-staging] Reset OOB packages from 7.0.7 (#86300)
carlossanlop Jun 13, 2023
861119c
Test Cleanup (#87450)
tarekgh Jun 13, 2023
9ccd2fb
Merge pull request #87452 from dotnet/release/7.0-staging
carlossanlop Jun 13, 2023
4c0f887
Merge in 'release/7.0' changes
dotnet-bot Jun 13, 2023
33b133c
Merge commit '5b20af47d99620150c53eaf5db8636fdf730b126' into internal…
vseanreesermsft Jun 13, 2023
4be8fd5
[7.0] Bump Microsoft.NETCore.Platforms (#87489)
carlossanlop Jun 13, 2023
3535197
[7.0-staging] Bump branding to 7.0.9 (#87455)
carlossanlop Jun 13, 2023
8f4c2eb
Merge in 'release/7.0' changes
dotnet-bot Jun 13, 2023
bd02510
Merge pull request #87462 from dotnet-maestro-bot/merge/release/7.0-t…
carlossanlop Jun 13, 2023
4c15f78
Merge pull request #87494 from vseanreesermsft/internal-merge-7.0-202…
carlossanlop Jun 13, 2023
c5dfa01
Merge in 'release/7.0' changes
dotnet-bot Jun 13, 2023
0656c91
[7.0] Reset System.Security.Cryptography.Pkcs OOB that came from inte…
carlossanlop Jun 13, 2023
156597d
Merge in 'release/7.0' changes
dotnet-bot Jun 13, 2023
5e11a1d
[release/7.0-staging] [MONO] Add JIT_CODE_DEBUG_INFO record functiona…
github-actions[bot] Jun 14, 2023
8196212
Merge pull request #87524 from dotnet-maestro-bot/merge/release/7.0-t…
carlossanlop Jun 14, 2023
9514ed2
mono_enable_jit_dump read access (#87427)
github-actions[bot] Jun 14, 2023
4141116
Update branding to 7.0.9 (#87776)
vseanreesermsft Jun 20, 2023
de47551
Merge in 'release/7.0' changes
dotnet-bot Jun 20, 2023
d83a556
[release/7.0] Update dependencies from dotnet/emsdk (#87696)
dotnet-maestro[bot] Jun 20, 2023
bf5972c
Update dependencies from https://github.com/dotnet/xharness build 202…
dotnet-maestro[bot] Jun 20, 2023
9721404
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] Jun 20, 2023
6141941
[release/7.0-staging] Update dependencies from dotnet/arcade dotnet/i…
dotnet-maestro[bot] Jun 20, 2023
f0bc957
Merged PR 32088: Merged PR 32017: [7.0] Fix regression loading null-p…
jeffhandley Jun 20, 2023
8e9a17b
Merge in 'release/7.0' changes
dotnet-bot Jun 20, 2023
083831e
[release/7.0-staging] dotnet.exe prints error messages to console whe…
github-actions[bot] Jun 26, 2023
d5ad559
[release/7.0-staging] [mono] ILStrip sorts custom attribute table (#8…
github-actions[bot] Jun 27, 2023
2251e9f
[release/7.0-staging] #76881 internal properties in GetRuntimePropert…
github-actions[bot] Jun 30, 2023
d46ca7e
Update branding to 7.0.10 (#88445)
vseanreesermsft Jul 6, 2023
671b932
[mono] Fix sorting custom attributes in ILStrip (#88437)
github-actions[bot] Jul 6, 2023
f0bd9b3
Update dependencies from https://github.com/dotnet/xharness build 202…
dotnet-maestro[bot] Jul 6, 2023
1636776
Update dependencies from https://github.com/dotnet/linker build 20230…
dotnet-maestro[bot] Jul 6, 2023
f5df552
Merge branch 'release/7.0-staging' into merge/release/7.0-to-release/…
carlossanlop Jul 6, 2023
6a230ce
Merge pull request #87804 from dotnet-maestro-bot/merge/release/7.0-t…
carlossanlop Jul 6, 2023
f7f2471
[release/7.0-staging][mono][debugger] Showing "Frame not in module" a…
thaystg Jul 10, 2023
eacc7bd
Revert Deflater/Inflater changes around SafeHandle initialization (#8…
github-actions[bot] Jul 10, 2023
062fd6f
[release/7.0-staging][wasm][debugger] Improve debugger performance (#…
thaystg Jul 10, 2023
f865846
Fix GetILFunctionBody for dynamic methods (#87530) (#87598)
davmason Jul 10, 2023
9ecb226
Disable mark list optimization if we hit a per region mark list overf…
cshung Jul 10, 2023
574b30d
[release/7.0-staging][wasm] CI: Fix EAT/AOT tests build (#87546)
radical Jul 10, 2023
bfb6e0c
Reset OOB packages from 7.0.8
carlossanlop Jul 11, 2023
e3034a1
Merge pull request #88646 from carlossanlop/release/7.0-staging
ViktorHofer Jul 11, 2023
4147d8e
Merge commit '8e9a17b2216f51a5788f8b1c467a4cf3b769e7d7' into internal…
vseanreesermsft Jul 11, 2023
fedb484
Merge pull request #88682 from vseanreesermsft/internal-merge-7.0-202…
carlossanlop Jul 12, 2023
d802116
Merge pull request #88652 from dotnet-maestro-bot/merge/release/7.0-t…
carlossanlop Jul 12, 2023
8d57046
[release/7.0-staging] Update dependencies from dotnet/arcade dotnet/i…
dotnet-maestro[bot] Jul 13, 2023
3aae244
[7.0] Backport "Fix MSBuild integration for the host build with CMake…
carlossanlop Jul 14, 2023
216f6ee
Skip RC2 encrypted PKCS12 files on Android for iteration counting (#8…
vcsjones Jul 17, 2023
028dc4f
[TestOnly] port test fixes (#89065)
tarekgh Jul 18, 2023
a00d6ad
[release/7.0-staging] Zlib: Update zlib to v1.2.13, intel-zlib to v1.…
github-actions[bot] Jul 27, 2023
a75fb66
[release/7.0-staging] [Mono] Look for Native Signal SIMD Context (#89…
github-actions[bot] Jul 27, 2023
a6b4969
Write perfmap and jitdump files to /tmp by default [7.0 port] (#89053)
tommcdon Jul 29, 2023
7e80916
Update dependencies from https://github.com/dotnet/xharness build 202…
dotnet-maestro[bot] Aug 1, 2023
b075459
[release/7.0-staging] Update dependencies from dotnet/hotreload-utils…
dotnet-maestro[bot] Aug 2, 2023
5266d23
[wasm] runtime: Fix creating the stack trace for a ManagedError
radical Aug 3, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
]
},
"microsoft.dotnet.xharness.cli": {
"version": "1.0.0-prerelease.22411.1",
"version": "7.0.0-prerelease.23321.1",
"commands": [
"xharness"
]
Expand Down
3 changes: 2 additions & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ dotnet_style_object_initializer = true:suggestion
dotnet_style_collection_initializer = true:suggestion
dotnet_style_explicit_tuple_names = true:suggestion
dotnet_style_coalesce_expression = true:suggestion
dotnet_style_null_propagation = true:suggestion
dotnet_style_null_propagation = false:suggestion # Turning off given new warnings that came with the new analyzers and we don't want to take the risk of changing those now
dotnet_style_prefer_compound_assignment = false:suggestion
dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
dotnet_style_prefer_inferred_tuple_names = true:suggestion
dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,4 @@ main PR <!-- Link to PR if any that fixed this in the main branch. -->

# Package authoring signed off?


IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary [package authoring](https://github.com/dotnet/runtime/blob/main/docs/project/library-servicing.md) and gotten it explicitly reviewed.
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary [package authoring](../../docs/project/library-servicing.md) and gotten it explicitly reviewed.
7 changes: 6 additions & 1 deletion .github/workflows/backport.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,9 @@ jobs:

## Risk

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary [package authoring](https://github.com/dotnet/runtime/blob/main/docs/project/library-servicing.md) and gotten it explicitly reviewed.
**IMPORTANT**: If this backport is for a servicing release, please verify that:

- The PR target branch is `release/X.0-staging`, not `release/X.0`.

- If the change touches code that ships in a NuGet package, you have added the necessary [package authoring](https://github.com/dotnet/runtime/blob/release/7.0/docs/project/library-servicing.md) and gotten it explicitly reviewed.

24 changes: 24 additions & 0 deletions .github/workflows/check-service-labels.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: check-service-labels

permissions:
pull-requests: read

on:
pull_request:
types: [opened, edited, reopened, labeled, unlabeled, synchronize]
branches:
- 'release/**'

jobs:
check-labels:
runs-on: ubuntu-latest
steps:
- name: Check 'Servicing-approved' label
run: |
echo "Merging permission is enabled for servicing PRs when the `Servicing-approved` label is applied."
if [ "${{ contains(github.event.pull_request.labels.*.name, 'Servicing-approved') }}" = "true" ]; then
exit 0
else
echo "::error:: 'Servicing-approved' label not applied to the PR yet. More information: https://github.com/dotnet/runtime/blob/main/docs/project/library-servicing.md#approval-process"
exit 1
fi
2 changes: 1 addition & 1 deletion Build.proj
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<Import Project="$(RepositoryEngineeringDir)SubsetValidation.targets" />

<!-- Upfront restore hooks -->
<Import Project="$(RepositoryEngineeringDir)restore\docs.targets" Condition="'$(DotNetBuildFromSource)' != 'true'" />
<Import Project="$(RepositoryEngineeringDir)restore\docs.targets" />
<Import Project="$(RepositoryEngineeringDir)restore\optimizationData.targets" Condition="'$(DotNetBuildFromSource)' != 'true'" />

<Target Name="BuildLocalTasks"
Expand Down
4 changes: 2 additions & 2 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
<NetCoreAppCurrentBrandName>.NET $(NetCoreAppCurrentVersion)</NetCoreAppCurrentBrandName>
<NetCoreAppCurrent>net$(NetCoreAppCurrentVersion)</NetCoreAppCurrent>
<NetCoreAppMinimum>net6.0</NetCoreAppMinimum>
<NetCoreAppMinimum Condition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppMinimum>

<NetCoreAppToolCurrentVersion>7.0</NetCoreAppToolCurrentVersion>
<NetCoreAppToolCurrent>net$(NetCoreAppToolCurrentVersion)</NetCoreAppToolCurrent>
Expand Down Expand Up @@ -90,7 +91,7 @@
<IbcOptimizationDataDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'ibc'))</IbcOptimizationDataDir>
<MibcOptimizationDataDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'mibc'))</MibcOptimizationDataDir>
<XmlDocDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'docs'))</XmlDocDir>
<XmlDocFileRoot>$([MSBuild]::NormalizeDirectory('$(NuGetPackageRoot)', 'microsoft.private.intellisense', '$(MicrosoftPrivateIntellisenseVersion)', 'IntellisenseFiles', 'net'))</XmlDocFileRoot>
<XmlDocFileRoot>$([MSBuild]::NormalizeDirectory('$(NuGetPackageRoot)', 'microsoft.private.intellisense', '$(MicrosoftPrivateIntellisenseVersion)', 'IntellisenseFiles'))</XmlDocFileRoot>
<DocsDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'docs'))</DocsDir>
<ManPagesDir>$([MSBuild]::NormalizeDirectory('$(DocsDir)', 'manpages'))</ManPagesDir>

Expand Down Expand Up @@ -273,7 +274,6 @@
<PackageProjectUrl>https://dot.net</PackageProjectUrl>
<Owners>microsoft,dotnetframework</Owners>
<IncludeSymbols>true</IncludeSymbols>
<RuntimeIdGraphDefinitionFile>$([MSBuild]::NormalizePath('$(LibrariesProjectRoot)', 'Microsoft.NETCore.Platforms', 'src', 'runtime.json'))</RuntimeIdGraphDefinitionFile>
<LicenseFile>$(MSBuildThisFileDirectory)LICENSE.TXT</LicenseFile>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
Expand Down
15 changes: 15 additions & 0 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,21 @@
<Import Project="$(RepositoryEngineeringDir)generators.targets" />
<Import Project="$(RepositoryEngineeringDir)python.targets" />

<!--
When .NET gets built from source, make the SDK aware there are bootstrap packages
for Microsoft.NETCore.App.Runtime.<rid> and Microsoft.NETCore.App.Crossgen2.<rid>.
-->
<ItemGroup Condition="'$(DotNetBuildFromSource)' == 'true'">
<KnownFrameworkReference Update="@(KnownFrameworkReference->WithMetadataValue('Identity', 'Microsoft.NETCore.App')->WithMetadataValue('TargetFramework', '$(NetCoreAppCurrent)'))">
<RuntimePackRuntimeIdentifiers>$(PackageRID)</RuntimePackRuntimeIdentifiers>
</KnownFrameworkReference>
<KnownCrossgen2Pack Update="@(KnownCrossgen2Pack->WithMetadataValue('Identity', 'Microsoft.NETCore.App.Crossgen2')->WithMetadataValue('TargetFramework', '$(NetCoreAppCurrent)'))">
<Crossgen2RuntimeIdentifiers>$(PackageRID)</Crossgen2RuntimeIdentifiers>
</KnownCrossgen2Pack>
<!-- Avoid references to Microsoft.AspNetCore.App.Runtime.<rid> -->
<KnownFrameworkReference Remove="Microsoft.AspNetCore.App" />
</ItemGroup>

<PropertyGroup>
<!--
Define this here (not just in Versions.props) because the SDK resets it
Expand Down
9 changes: 9 additions & 0 deletions NuGet.config
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@
</fallbackPackageFolders>
<packageSources>
<clear />
<!--Begin: Package sources managed by Dependency Flow automation. Do not edit the sources below.-->
<!-- Begin: Package sources from dotnet-emsdk -->
<add key="darc-pub-dotnet-emsdk-fcd8602" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-fcd86021/nuget/v3/index.json" />
<add key="darc-pub-dotnet-emsdk-9b227c1" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-9b227c16/nuget/v3/index.json" />
<add key="darc-pub-dotnet-emsdk-9b227c1-2" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-9b227c16-2/nuget/v3/index.json" />
<add key="darc-pub-dotnet-emsdk-9b227c1-1" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-9b227c16-1/nuget/v3/index.json" />
<add key="darc-pub-dotnet-emsdk-96ba1fe" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-96ba1fed/nuget/v3/index.json" />
<!-- End: Package sources from dotnet-emsdk -->
<!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.-->
<!--
'src/test/PrepareTestAssets/PrepareTestAssets.proj' generates a NuGet.config file using this
one as a template. The following line is a marker to insert the test restore sources.
Expand Down
2 changes: 1 addition & 1 deletion THIRD-PARTY-NOTICES.TXT
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ https://github.com/madler/zlib
https://zlib.net/zlib_license.html

/* zlib.h -- interface of the 'zlib' general purpose compression library
version 1.2.12, March 27th, 2022
version 1.2.13, October 13th, 2022

Copyright (C) 1995-2022 Jean-loup Gailly and Mark Adler

Expand Down
54 changes: 42 additions & 12 deletions docs/design/coreclr/jit/viewing-jit-dumps.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,29 +120,59 @@ These can be set in one of three ways:

## Specifying method names

The complete syntax for specifying a single method name (for a flag that takes a method name, such as `COMPlus_JitDump`) is:

Some environment variables such as `COMPlus_JitDump` take a set of patterns specifying method names. The matching works in the following way:
* A method set string is a space-separated list of patterns. Patterns can arbitrarily contain both '*' (match any characters) and '?' (match any 1 character).
* The string matched against depends on characters in the pattern:
+ If the pattern contains a ':' character, the string matched against is prefixed by the class name and a colon
+ If the pattern contains a '(' character, the string matched against is suffixed by the signature
+ If the class name (part before colon) contains a '[', the class contains its generic instantiation
+ If the method name (part between colon and '(') contains a '[', the method contains its generic instantiation

In particular, the matching is done against strings of the following format which coincides with how the JIT displays method signatures (so these can be copy pasted into the environment variable).
```
[[<Namespace>.]<ClassName>::]<MethodName>[([<types>)]
[ClassName[Instantiation]:]MethodName[Instantiation][(<types>)]
```

For example
For example, consider the following:
```csharp
namespace MyNamespace
{
public class C<T1, T2>
{
[MethodImpl(MethodImplOptions.NoInlining)]
public void M<T3, T4>(T1 arg1, T2 arg2, T3 arg3, T4 arg4)
{
}
}
}

```
System.Object::ToString(System.Object)
new C<sbyte, string>().M<int, object>(default, default, default, default); // compilation 1
new C<int, int>().M<int, int>(default, default, default, default); // compilation 2
```

The namespace, class name, and argument types are optional, and if they are not present, default to a wildcard. Thus stating:
The full names of these instantiations are the following, as printed by `COMPlus_JitDisasmSummary`:

```
Main
MyNamespace.C`2[byte,System.__Canon]:M[int,System.__Canon](byte,System.__Canon,int,System.__Canon)
MyNamespace.C`2[int,int]:M[int,int](int,int,int,int)
```
Note that ``C`2`` here is the name put into metadata by Roslyn; the suffix is not added by RyuJIT.
For Powershell users keep in mind that backtick is the escape character and itself has to be escaped via double backtick.

will match all methods named Main from any class and any number of arguments.

`<types>` is a comma separated list of type names. Note that presently only the number of arguments and not the types themselves are used to distinguish methods. Thus, `Main(Foo, Bar)` and `Main(int, int)` will both match any main method with two arguments.
The following strings will match both compilations:
```
M
*C`2:M
*C`2[*]:M[*](*)
MyNamespace.C`2:M
```

The wildcard character `*` can be used for `<ClassName>` and `<MethodName>`. In particular `*` by itself indicates every method.
The following match only the first compilation:
```
M[int,*Canon]
MyNamespace.C`2[byte,*]:M
M(*Canon)
```

## Useful COMPlus variables

Expand Down
2 changes: 1 addition & 1 deletion docs/design/features/OsrDetailsAndDebugging.md
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ Note if a Tier0 method is recursive and has loops there can be some interesting

### Seeing which OSR methods are created

* `DOTNET_DumpJittedMethods=1` will specially mark OSR methods with the inspiring IL offsets.
* `DOTNET_JitDisasmSummary=1` will specially mark OSR methods with the inspiring IL offsets.

For example, running a libraries test with some stressful OSR settings, there ended up being 699 OSR methods jitted out of 160675 total methods. Grepping for OSR in the dump output, the last few lines were:

Expand Down
33 changes: 31 additions & 2 deletions docs/project/library-servicing.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
# How to service a library

This document provides the steps necessary after modifying a library in a servicing branch (where "servicing branch" refers to any branch whose name begins with `release/`).
This document provides the steps that need to be followed after modifying a library in a servicing branch.

Servicing branches represent shipped versions of .NET, and their name is in the format `release/X.0-staging`. Examples:

- `release/7.0-staging`
- `release/6.0-staging`

## Check if a package is generated

If a library is packable (check for the `<IsPackable>true</IsPackable>` property) you'll need to set `<GeneratePackageOnBuild>true</GeneratePackageOnBuild>` in the source project. That is necessary as packages aren't generated by default in servicing releases.

Additionally, if the library is listed among the project references of [Microsoft.Windows.Compatibility.csproj](https://github.com/dotnet/runtime/blob/43bb5993d4f983e9d575f52b691ecdc9b9e257ef/src/libraries/Microsoft.Windows.Compatibility/src/Microsoft.Windows.Compatibility.csproj#L15-L48), please make sure to bump the value of `ServicingVersion` for `Microsoft.Windows.Compatibility.csproj` and also set its `GeneratePackageOnBuild` property value to `true`. The version number must only be bumped once per servicing release, even if multiple dependencies get modified.

## Determine ServiceVersion

When you make a change to a library & ship it during the servicing release, the `ServicingVersion` must be bumped. This property is found in the library's source project. It's also possible that the property is not in that file, in which case you'll need to add it to the library's source project and set it to 1. If the property is already present in your library's source project, just increment the servicing version by 1.
Expand All @@ -23,4 +30,26 @@ All that's left is to ensure that your changes have worked as expected. To do so

## Approval Process

All the servicing change must go through an approval process. Please create your PR using [this template](https://raw.githubusercontent.com/dotnet/runtime/main/.github/PULL_REQUEST_TEMPLATE/servicing_pull_request_template.md). You should also add `servicing-consider` label to the pull request and bring it to the attention of the engineering lead responsible for the area.
All the servicing change must go through an approval process. You have two ways to submit your PR:

- By manually creating your PR using [this template](https://raw.githubusercontent.com/dotnet/runtime/main/.github/PULL_REQUEST_TEMPLATE/servicing_pull_request_template.md).
- Or by asking the bot to automatically create the servicing PR for you using a merged `main` PR as source. This method requires typing an AzDO backport command as a comment of your merged PR using the format `/backport to release/X.0-staging`. Examples:
-
- `/backport to release/7.0-staging`
- `/backport to release/6.0-staging`

For both cases, you must:

- Fill out the template of the PR description.
- Bring it to the attention of the [engineering lead responsible for the area](~/docs/area-owners.md).
- If the fix is a product change, the area owner will:
- Add the `Servicing-consider` label.
- Ask the area owner to champion your PR in the .NET Tactics meeting to request merge approval.
- If the change is approved, they will replace the `Servicing-consider` label by `Servicing-approved` and sign-off the PR.
- If the fix is a test-only or infra-only change, the area owner will:
- Review the PR and sign-off if they approve it.
- Add the `Servicing-approved` label.

The area owner can then merge the PR once the CI looks good (it's either green or the failures are investigated and determined to be unrelated to the PR).

**Note**: Applying the `Servicing-approved` label ensures the `check-service-labels` CI job passes, which is a mandatory requirement for merging a PR in a servicing branch.
2 changes: 1 addition & 1 deletion docs/workflow/testing/testing-workloads.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Workloads based on packages in `artifacts` can be installed, and used for testing.

- This is done by installing a specified SDK version (`$(SdkVersionForWorkloadTesting)`) in `artifacts/bin/dotnet-workload`.
- This is done by installing a specified SDK version (`$(SdkVersionForWorkloadTesting)`) in `artifacts/bin/dotnet-net7`.
- Then the manifest for the workload in `@(WorkloadIdForTesting)` is installed
- Then workload packs are installed
- packs, or manifests not generated by `runtime`, are restored from nuget
Expand Down
41 changes: 8 additions & 33 deletions eng/Signing.props
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<Project InitialTargets="SetupFilesToSign">

<Project>
<PropertyGroup>
<!--
Windows arm/arm64 jobs don't have MSIs to sign. Keep it simple: allow not finding any matches
Expand All @@ -20,6 +19,13 @@
<!-- apphost and comhost template files are not signed, by design. -->
<FileSignInfo Include="apphost.exe;singlefilehost.exe;comhost.dll" CertificateName="None" />

<!--
The DAC and the DBI must go through special signing provisioning using a system separate
from MicroBuild.
-->
<FileSignInfo Include="mscordaccore.dll" CertificateName="None" />
<FileSignInfo Include="mscordbi.dll" CertificateName="None" />

<!-- We don't need to code sign .js files because they are not used in Windows Script Host. -->
<!-- WARNING: Needs to happed outside of any target -->
<FileExtensionSignInfo Update=".js" CertificateName="None" />
Expand All @@ -31,8 +37,6 @@
<FileSignInfo Include="Mono.Cecil.Pdb.dll" CertificateName="3PartySHA2" />
<FileSignInfo Include="Mono.Cecil.Rocks.dll" CertificateName="3PartySHA2" />

<FileSignInfo Include="mscordaccore.dll" CertificateName="MicrosoftSHA2" />

<!-- Exclude symbol packages from have a NuGet signature. These are never pushed to NuGet.org or
other feeds (in fact, that have identical identity to their non-symbol variant) -->
<DownloadedSymbolPackages Include="$(DownloadDirectory)**\*.symbols.nupkg" />
Expand Down Expand Up @@ -61,33 +65,4 @@
<ItemsToSignPostBuild Include="@(ItemsToSignWithoutPaths->Distinct())" Condition="'$(PostBuildSign)' == 'true'" />
<ItemsToSign Include="@(ItemsToSignWithPaths->Distinct())" Condition="'$(PostBuildSign)' != 'true'" />
</ItemGroup>

<Target Name="SetupFilesToSign">
<!-- Ensure that we don't miss the DAC or DBI with the globbing below -->
<PropertyGroup Condition="'$(SignDiagnostics)' == 'true' or '$(SignDiagnosticsPackages)' == 'true'">
<AllowEmptySignList>false</AllowEmptySignList>
</PropertyGroup>

<ItemGroup Condition="'$(SignDiagnostics)' == 'true'">
<ItemsToSign Include="$(DiagnosticsFilesRoot)\**\mscordaccore*.dll" />
<ItemsToSign Include="$(DiagnosticsFilesRoot)\**\mscordbi.dll" />
<!--
The DAC should be signed with the SHA2 cert (both long and short name).
We already add the short-name DAC above, so add the long-name DAC here.
-->
<DacFileSignInfo Include="@(ItemsToSign->'%(FileName)%(Extension)')"
Condition="$([System.String]::new('%(FileName)').StartsWith('mscordaccore'))" />
<FileSignInfo Include="@(DacFileSignInfo->ClearMetadata()->Distinct())"
Exclude="mscordaccore.dll"
CertificateName="MicrosoftSHA2" />
</ItemGroup>

<ItemGroup Condition="'$(SignDiagnosticsPackages)' == 'true'">
<!-- The cross OS diagnostics symbol packages need to be signed as they are the only packages
that have a specific version of assets that are only meant to be indexed in symbol servers.
Since only *symbols.nupkg get indexed, and installer doesn't produce these, we need to glob them for signing. -->
<ItemsToSign Include="$(PackagesFolder)\**\*CrossOsDiag*.nupkg" />
</ItemGroup>
</Target>

</Project>
Loading