release/7.0 staging #89904
Closed
release/7.0 staging #89904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevent unwinding through stack bottom When processing unhandled exception on the most recent Alpine 3.17, the libunwind doesn't stop at the bottom frame of the main thread (the caller of `main`) and tries to unwind further. The reason is that the method is missing dwarf unwind information, so the libunwind falls back to using RBP chain, but the RBP points to a garbage and so it ends up crashing with SIGSEGV. While the missing DWARF unwind info seems to be a bug in the Alpine 3.17 (older ones work fine), we can prevent issues like this by stopping at the hosting API boundary and not trying to unwind past that. This is what this PR does. * Fix bug introduced by preventing unwind through stack bottom (dotnet#81956) The irecent fix to prevent unwinding through stack bottom was incorrect for secondary threads, as it just compared the SP being above the frame of the hosting API. However, other threads can have their stacks anywhere in the memory, thus this sometimes broke exception handling on secondary threads. I have also found that there was one more case where the unwind through the hosting API need to be checked - the Thread::VirtualUnwindToFirstManagedCallFrame. I have decided to use the return address of the hosting API for the checks instead of the frame address. That makes the check work properly. --------- Co-authored-by: Jan Vorlicek <[email protected]>
…#81878) (dotnet#82063) * Fix XmlSqlBinaryReader and introduce a corpus of SqlXml tests * Revert solution file changes made by VS * Use runtime-assets test files for Text and SQL Binary XML tests * Remove System.Data.Common.TestData package reference * Reference the System.Data.Common.TestData package for SqlXml tests * Add System.Common.Data.TestData to Version.Details.xml for automated dependency flow
…-merge-7.0-2023-02-14-1048
….0-2023-02-14-1048 Merging internal commits for release/7.0
…214.3 (dotnet#82171) Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.23060.4 -> To Version 7.0.0-beta.23114.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update branding to 7.0.5 * Reset OOB packages from the previous month. --------- Co-authored-by: carlossanlop <[email protected]>
…ions instead (dotnet#83100) * Fix superpmi_collect-setup.py helix images to use floating instead Per the suggestions here: dotnet#81712 (comment) * Update comment at the top --------- Co-authored-by: carlossanlop <[email protected]>
…time-assets (dotnet#82089) * Update dependencies from https://github.com/dotnet/llvm-project build 20230213.2 runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools From Version 11.1.0-alpha.1.23080.2 -> To Version 11.1.0-alpha.1.23113.2 * Update dependencies from https://github.com/dotnet/runtime-assets build 20230213.5 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 7.0.0-beta.22553.1 -> To Version 7.0.0-beta.23113.5 * Update dependencies from https://github.com/dotnet/llvm-project build 20230215.1 runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools From Version 11.1.0-alpha.1.23080.2 -> To Version 11.1.0-alpha.1.23115.1 * Update dependencies from https://github.com/dotnet/llvm-project build 20230215.1 runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools From Version 11.1.0-alpha.1.23080.2 -> To Version 11.1.0-alpha.1.23115.1 * Update dependencies from https://github.com/dotnet/runtime-assets build 20230222.2 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 7.0.0-beta.22553.1 -> To Version 7.0.0-beta.23122.2 * Update dependencies from https://github.com/dotnet/runtime-assets build 20230224.4 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 7.0.0-beta.22553.1 -> To Version 7.0.0-beta.23124.4 * Update dependencies from https://github.com/dotnet/runtime-assets build 20230224.4 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 7.0.0-beta.22553.1 -> To Version 7.0.0-beta.23124.4 * Update dependencies from https://github.com/dotnet/runtime-assets build 20230301.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 7.0.0-beta.22553.1 -> To Version 7.0.0-beta.23151.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Carlos Sánchez López <[email protected]>
….1 (dotnet#82174) Microsoft.NETCore.Runtime.ICU.Transport From Version 7.0.0-rtm.23061.2 -> To Version 7.0.0-rtm.23115.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Carlos Sánchez López <[email protected]>
…tnet#82851) Co-authored-by: Tom Deseyn <[email protected]> Co-authored-by: Alexander Köplinger <[email protected]>
…82268) * [workloads] Backport UsingMobileWorkload change Backport of dotnet#77489 Adds the UsingMobileWorkload property along with a tighter check on when to import the aot task * Add aot task condition to net6 --------- Co-authored-by: Steve Pfister <[email protected]> Co-authored-by: Carlos Sánchez López <[email protected]>
…tnet#82219) Fixes 7.0 perf runs: ``` Traceback (most recent call last): File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 373, in <module> __main(sys.argv[1:]) File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 318, in __main dotnet_version = dotnet.get_dotnet_version(target_framework_moniker, args.cli) if args.dotnet_versions == [] else args.dotnet_versions[0] File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 549, in get_dotnet_version sdk_path = get_sdk_path(dotnet_path) if sdk_path is None else sdk_path File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 533, in get_sdk_path base_path = get_base_path(dotnet_path) File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 527, in get_base_path 'Did not find "Base Path:" entry on the `dotnet --info` command' RuntimeError: Did not find "Base Path:" entry on the `dotnet --info` command ``` Co-authored-by: Carlos Sánchez López <[email protected]>
…4KiB. (dotnet#82082) * System.Console: allow terminfo files to be larger than 4KiB. * Remove file size check. --------- Co-authored-by: Tom Deseyn <[email protected]>
…et#82617) * fix assets counting * test that we could retry asset downloads * nicer * feedback
Linux Watson needs this to better triage ELF dumps. Add CreateDumpOptions helper struct to pass all the command options around. Add the "--code", "--errno", "--address" command line options used to fill the NT_SIGINFO NOTE. The runtime passes to createdump on a crash. Added "ExceptionType" field to "Parameters" section of the Linux crash report json.
The native runtime event implementations for nativeaot and GC use pthread_cond_wait to wait for the event and pthread_cond_broadcast to signal that the event was set. While the usage of the pthread_cond_broadcast conforms with the documentation, it turns out that glibc before 2.25 had a race in the implementation that can cause the pthread_cond_broadcast to be unnoticed and the wait waiting forever. It turns out that macOS implementation has the same issue. The fix for the issue is to call pthread_cond_broadcast while the related mutex is taken. This change fixes intermittent crossgen2 hangs with nativeaot build of crossgen2 reported in dotnet#81570. I was able to repro the hang locally in tens of thousands of iterations of running crossgen2 without any arguments (the hang occurs when server GC creates threads). With this fix, it ran without problems over the weekend, passing 5.5 million iterations. Co-authored-by: Jan Vorlicek <[email protected]>
… 3.26" (dotnet#88809) * [7.0] Backport "Fix MSBuild integration for the host build with CMake 3.26" * net8.0 -> net7.0
…2.13_jtk (dotnet#89517) * Update zlib -> 1.2.13 * Update intel zlib -> 1.2.13_jtk * Revert readme, cherry-pick changes * Delete zlib.3.pdf * Update zlib version text files. --------- Co-authored-by: Levi Broderick <[email protected]> Co-authored-by: Levi Broderick <[email protected]>
…net#89568) * Find Navtive Signal SIMD Context * Fix coding format * Set fregs to 0 when SIMD registers were not found --------- Co-authored-by: Fan Yang <[email protected]>
…#89053) * Write perfmap and jitdump files to /tmp by default * Simplify perfmap path generation * Minor comment update --------- Co-authored-by: David Mason <[email protected]>
…30621.1 (dotnet#88766) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 7.0.0-prerelease.23309.1 -> To Version 7.0.0-prerelease.23321.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Carlos Sánchez López <[email protected]>
… dotnet/linker dotnet/emsdk (dotnet#89008) * Update dependencies from https://github.com/dotnet/hotreload-utils build 20230717.2 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 7.0.0-alpha.0.23316.2 -> To Version 7.0.0-alpha.0.23367.2 * Update dependencies from https://github.com/dotnet/linker build 20230801.1 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.23321.1 -> To Version 7.0.100-1.23401.1 * Update dependencies from https://github.com/dotnet/emsdk build 20230801.3 Microsoft.NET.Workload.Emscripten.net6.Manifest-7.0.100 , Microsoft.NET.Workload.Emscripten.net7.Manifest-7.0.100 From Version 7.0.10 -> To Version 7.0.11 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Carlos Sánchez López <[email protected]>
With the latest chrome (`115.*`) the following code in
`runtime/marshal.ts` fails because `this.superStack.value` is no longer
available:
```js
getSuperStack() {
if (this.superStack) {
return this.superStack.value;
}
return super.stack; // this works on FF
}
```
This causes the final error to not have the original managed error
message, and also have a `"undefined"` at the end of the string.
Truncated error missing the native part of the stack, and the message:
```
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.ThrowFromJSExport(String message)
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.__Wrapper_ThrowFromJSExport_271731536(JSMarshalerArgument* __arguments_buffer)
undefined
```
With the fix:
```
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.ThrowFromJSExport(String message)
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.__Wrapper_ThrowFromJSExport_817705034(JSMarshalerArgument* __arguments_buffer)
Error: -t-e-s-t-
at sr (http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:33284)
at Br (http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:42679)
at http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:40825
at Module.catch1stack (http://127.0.0.1:60345/JavaScriptTestHelper.mjs:132:9)
at http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:36627
at mr (http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:37821)
at do_icall (http://127.0.0.1:60345/_framework/dotnet.native.wasm:wasm-function[221]:0x19711)
at do_icall_wrapper (http://127.0.0.1:60345/_framework/dotnet.native.wasm:wasm-function[108]:0x157bc)
at mono_interp_exec_method (http://127.0.0.1:60345/_framework/dotnet.native.wasm:wasm-function[101]:0x9c92)
at interp_runtime_invoke (http://127.0.0.1:60345/_framework/dotnet.native.wasm:wasm-function[141]:0x16cd7)
```
Thanks to @kg for the fix.
(cherry picked from commit 89f6429)
radical
requested review from
lewing,
pavelsavara,
thaystg,
kg,
lambdageek,
vargaz,
BrzVlad,
SamMonoRT,
kotlarmilos,
lateralusX,
marek-safar and
MichalStrehovsky
as code owners
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-io Issue Details
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSExporton struct and records ([release/7.0] [wasm] FixJSExporton struct and records #74890)IsValidCompareChainshould returnfalseif both operands are not integral types ([release/7.0] [ARM64] -IsValidCompareChainshould returnfalseif both operands are not integral types #75016)FIELD_LISTs on x86 ([release/7.0] Do not retype small locals inFIELD_LISTs on x86 #75036)ITypeInfo([release/7.0] Fix W^X flag for settingITypeInfo#75046)runtime-wasmfor PRs ([release/7.0][wasm] Add CI job for AOT+SIMD toruntime-wasmfor PRs #75064)Exp10M1(TSelf)andRound(TSelf, MidpointRounding)([release/7.0] FixExp10M1(TSelf)andRound(TSelf, MidpointRounding)#75284)dotnet-runtime-perf#75408)Microsoft.Build.NoTargets([release/7.0][wasm] Fix reference toMicrosoft.Build.NoTargets#75472)Vector128<T> AsVector128(this Vector<T> value)) doesn't have a side-effect in its assert ([release/7.0] Ensure NI_Vector128_AsVector128 (akaVector128<T> AsVector128(this Vector<T> value)) doesn't have a side-effect in its assert #76547)runtime-extra-platformswith batched builds for release (CI: Runruntime-extra-platformswith batched builds for release #76587) ([release/7.0] CI: Runruntime-extra-platformswith batched builds for release #76615)JsonIgnoreAttributehandling of unsupported property types #76869)IMemoryViewas exported type ([release/7.0] [wasm] AddIMemoryViewas exported type #77397)LOADERHANDLEDispatchMemberInfodtor #77570)SequenceNumberbefore reading theItem([release/7.0] Fixing memory ordering issue in ConcurrentQueue #78178)pingon Android API 21-27 #80120)pingon Samsung phones ([release/7.0] Fix parsing the output ofpingon Samsung phones #80502)SerialPort) ([7.0] Fix reporting of an async IO timeout error on Windows (SerialPort) #81745)