-
Notifications
You must be signed in to change notification settings - Fork 5k
Mono - Add error on warnings #67926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mono - Add error on warnings #67926
Conversation
Tagging subscribers to this area: @directhex Issue DetailsContributes to #66154 /cc @lambdageek @vargaz @lateralusX
|
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
@lambdageek Yay for green! |
@lateralusX we should really build with clang with |
Yes, that was one of the reasons I didn't enable the warnings as errors in my previous bump to W4 on Windows, so I would have suggested that we added some additional warnings to OSX as well. |
@AaronRobinsonMSFT we should also have dropped the section where we bump some warnings to errors in config.h.in, but I can do a PR during the day that take care of that as well as looking at doing some more warnings on OSX (the once that currently make sense, since we have still not enabled all needed warnings on Windows). |
@lateralusX Apologies in aggressively merging in the changes. Let me know how I can help move this forward to satisfy #66154. I really want to get the inner dev loop in a good state so no more violations crop up. Warnings C4018 and C4244 are very common and will take some time to address. Hopefully we can avoid adding more of them. |
Contributes to #66154
/cc @lambdageek @vargaz @lateralusX