Mono - Add error on warnings (#67926)

* Mono - Add error on warnings

* Use standard macro for uint8_t max size.

Author: AaronRobinsonMSFT

src/mono/CMakeLists.txt

@@ -264,6 +264,7 @@ elseif(CMAKE_SYSTEM_NAME STREQUAL "Windows")
   set(INTERNAL_ZLIB 1)
   set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>") # statically link VC runtime library
   add_compile_options(/W4)   # set warning level 4
+  add_compile_options($<$<COMPILE_LANGUAGE:C,CXX>:/WX>) # treat warnings as errors
   add_compile_options(/EHsc) # set exception handling behavior
   add_compile_options(/FC)   # use full pathnames in diagnostics
   add_link_options(/STACK:0x800000)  # set stack size to 8MB (default is 1MB)

src/mono/mono/component/debugger-protocol.c

@@ -14,15 +14,17 @@ static int32_t packet_id = 0;
 int
 m_dbgprot_buffer_add_command_header (MdbgProtBuffer *data, int command_set, int command, MdbgProtBuffer *out)
 {
+	g_assert (command_set <= UINT8_MAX);
+	g_assert (command <= UINT8_MAX);
 	int id = dbg_rt_atomic_inc_int32_t ((volatile int32_t *)&packet_id);
 
 	uint32_t len = (uint32_t)(data->p - data->buf + HEADER_LENGTH);
 	m_dbgprot_buffer_init (out, len);
 	m_dbgprot_buffer_add_int (out, len);
 	m_dbgprot_buffer_add_int (out, id);
 	m_dbgprot_buffer_add_byte (out, 0); /* flags */
-	m_dbgprot_buffer_add_byte (out, command_set);
-	m_dbgprot_buffer_add_byte (out, command);
+	m_dbgprot_buffer_add_byte (out, (uint8_t)command_set);
+	m_dbgprot_buffer_add_byte (out, (uint8_t)command);
 	m_dbgprot_buffer_add_data (out, data->buf, (uint32_t) (data->p - data->buf));
 	return id;
 }

src/mono/mono/metadata/object-internals.h

@@ -241,7 +241,7 @@ mono_array_handle_length (MonoArrayHandle arr)
 // in order to mimic non-_internal but without the GC mode transitions, or at least,
 // to avoid the runtime using the embedding API, whether or not it has GC mode transitions.
 static inline char*
-mono_array_addr_with_size_internal (MonoArray *array, int size, uintptr_t idx)
+mono_array_addr_with_size_internal (MonoArray *array, size_t size, uintptr_t idx)
 {
 	return mono_array_addr_with_size_fast (array, size, idx);
 }

src/mono/mono/metadata/sysmath.c

@@ -214,7 +214,7 @@ ves_icall_System_MathF_Asinh  (float x)
 float
 ves_icall_System_MathF_Atan  (float x)
 {
-	return atan (x);
+	return atanf (x);
 }
 
 float
@@ -292,7 +292,7 @@ ves_icall_System_MathF_Sin (float x)
 float
 ves_icall_System_MathF_Sinh (float x)
 {
-	return sinh (x);
+	return sinhf (x);
 }
 
 float
@@ -310,7 +310,7 @@ ves_icall_System_MathF_Tan (float x)
 float
 ves_icall_System_MathF_Tanh (float x)
 {
-	return tanh (x);
+	return tanhf (x);
 }
 
 float

src/mono/mono/mini/mini-amd64.c

@@ -8108,7 +8108,7 @@ mono_arch_emit_epilog (MonoCompile *cfg)
 	for (i = 0; i < AMD64_NREG; ++i) {
 		if (AMD64_IS_CALLEE_SAVED_REG (i) && (cfg->arch.saved_iregs & (1 << i))) {
 			/* Restore only used_int_regs, not arch.saved_iregs */
-			int restore_reg = (cfg->used_int_regs & (1 << i));
+			size_t restore_reg = (cfg->used_int_regs & (size_t)(1 << i));
 			if (restore_reg) {
 				amd64_mov_reg_membase (code, i, cfg->frame_reg, save_area_offset, 8);
 				mono_emit_unwind_op_same_value (cfg, code, i);