Add hot reload test that adds custom attributes #53387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @tommcdon Issue DetailsThis test adds new rows to the CustomAttribute table with both new a class and
|
This test adds new rows to the CustomAttribute table with both new a class and a new method as parents. That should result in an unsorted table, which CoreCLR should be able to handle.
lambdageek
force-pushed
the
add-custom-attribute-add-test
branch
from
c95d432 to
53eb701
Compare
Looking up the new class using System.Reflection.Assembly.GetType wasn't working.
lambdageek
force-pushed
the
add-custom-attribute-add-test
branch
from
c9f9f8f to
36284c5
Compare
lambdageek
force-pushed
the
add-custom-attribute-add-test
branch
from
36284c5 to
5a46b5c
Compare
|
Looks like the test is passing on CoreCLR. Seems we're in the clear for #53066 |
mikem8361
reviewed
Jun 1, 2021
| @@ -133,5 +133,26 @@ internal static void AddRemoteInvokeOptions (ref RemoteInvokeOptions options) | |||
| testBody(arg1); | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| public static void ClearAllReflectionCaches() | |||
There was a problem hiding this comment.
It would be nice someday to use the more general update handler logic from the SDK here somehow. It should work for mono too.
mikem8361
approved these changes
Jun 1, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test adds new rows to the CustomAttribute table with both new a class and
a new method as parents. That should result in an unsorted table, which
CoreCLR should be able to handle.