Add hot reload test that adds custom attributes

This test adds new rows to the CustomAttribute table with both new a class and
a new method as parents.  That should result in an unsorted table, which
CoreCLR should be able to handle.

Author: lambdageek

src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.ClassWithCustomAttributes/ClassWithCustomAttributes.cs

@@ -0,0 +1,18 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+using System;
+
+
+namespace System.Reflection.Metadata.ApplyUpdate.Test
+{
+    [Obsolete]
+    public class ClassWithCustomAttributes {
+        [Obsolete]
+        public static string Method () {
+            return null;
+        }
+    }
+}
+
+
+    

src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.ClassWithCustomAttributes/ClassWithCustomAttributes_v1.cs

@@ -0,0 +1,26 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+using System;
+
+
+namespace System.Reflection.Metadata.ApplyUpdate.Test
+{
+    [Obsolete]
+    public class ClassWithCustomAttributes {
+        [Obsolete]
+        public static string Method () {
+            return null;
+        }
+    }
+
+    [Obsolete]
+    public class ClassWithCustomAttributes2 {
+        [Obsolete]
+        public static string Method2 () {
+            return null;
+        }
+    }
+}
+
+
+    

src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.ClassWithCustomAttributes/System.Reflection.Metadata.ApplyUpdate.Test.ClassWithCustomAttributes.csproj

@@ -0,0 +1,11 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <RootNamespace>System.Runtime.Loader.Tests</RootNamespace>
+    <TargetFrameworks>$(NetCoreAppCurrent)</TargetFrameworks>
+    <TestRuntime>true</TestRuntime>
+    <DeltaScript>deltascript.json</DeltaScript>
+  </PropertyGroup>
+  <ItemGroup>
+    <Compile Include="ClassWithCustomAttributes.cs" />
+  </ItemGroup>
+</Project>

src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.ClassWithCustomAttributes/deltascript.json

@@ -0,0 +1,6 @@
+{
+    "changes": [
+        {"document": "ClassWithCustomAttributes.cs", "update": "ClassWithCustomAttributes_v1.cs"},
+    ]
+}
+

src/libraries/System.Runtime.Loader/tests/ApplyUpdateTest.cs

@@ -38,5 +38,49 @@ void StaticMethodBodyUpdate()
                 Assert.Equal ("NEWEST STRING", r);
             });
         }
+
+        [Fact]
+        [ActiveIssue("xyz", TestRuntimes.Mono)]
+        void ClassWithCustomAttributes()
+        {
+            ApplyUpdateUtil.TestCase(static () =>
+            {
+                // Get the custom attribtues from the newly-added type and method and check
+                // That they are the expected ones
+                var className = "System.Reflection.Metadata.ApplyUpdate.Test.ClassWithCustomAttributes2";
+                var methodName = "Method2";
+#pragma warning disable CS0612
+                var assm = typeof(ApplyUpdate.Test.ClassWithCustomAttributes).Assembly;
+#pragma warning restore CS0612
+
+                var ty = assm.GetType(className, throwOnError: false);
+
+                Assert.Null (ty);
+
+                ApplyUpdateUtil.ApplyUpdate(assm);
+
+                ty = assm.GetType(className, throwOnError: false);
+
+                Assert.NotNull (ty);
+
+                var cattrs = Attribute.GetCustomAttributes(ty);
+
+                Assert.NotNull(cattrs);
+                Assert.Equal(1, cattrs.Length);
+                Assert.NotNull(cattrs[0]);
+                Assert.Equal(typeof(ObsoleteAttribute), cattrs[0].GetType());
+
+                var mi = ty.GetMethod(methodName, BindingFlags.Public | BindingFlags.Static);
+
+                Assert.NotNull (mi);
+
+                cattrs = Attribute.GetCustomAttributes(mi);
+
+                Assert.NotNull(cattrs);
+                Assert.Equal(1, cattrs.Length);
+                Assert.NotNull(cattrs[0]);
+                Assert.Equal(typeof(ObsoleteAttribute), cattrs[0].GetType());
+            });
+        }
     }
 }

src/libraries/System.Runtime.Loader/tests/System.Runtime.Loader.Tests.csproj

@@ -39,6 +39,8 @@
     <ProjectReference Include="LoaderLinkTest.Shared\LoaderLinkTest.Shared.csproj" />
     <ProjectReference Include="LoaderLinkTest.Dynamic\LoaderLinkTest.Dynamic.csproj" />
     <ProjectReference Include="ApplyUpdate\System.Reflection.Metadata.ApplyUpdate.Test.MethodBody1\System.Reflection.Metadata.ApplyUpdate.Test.MethodBody1.csproj" />
+    <ProjectReference Include="ApplyUpdate\System.Reflection.Metadata.ApplyUpdate.Test.ClassWithCustomAttributes\System.Reflection.Metadata.ApplyUpdate.Test.ClassWithCustomAttributes.csproj" />
+
   </ItemGroup>
   <ItemGroup Condition="'$(TargetOS)' == 'Browser'">
     <WasmFilesToIncludeFromPublishDir Include="$(AssemblyName).dll" />
@@ -54,6 +56,9 @@
       <TrimmerRootAssembly
           Condition="$([System.String]::Copy('%(ResolvedFileToPublish.FileName)%(ResolvedFileToPublish.Extension)').EndsWith('System.Reflection.Metadata.ApplyUpdate.Test.MethodBody1.dll'))"
           Include="%(ResolvedFileToPublish.FullPath)" />
+      <TrimmerRootAssembly
+          Condition="$([System.String]::Copy('%(ResolvedFileToPublish.FileName)%(ResolvedFileToPublish.Extension)').EndsWith('System.Reflection.Metadata.ApplyUpdate.Test.ClassWithCustomAttributes.dll'))"
+          Include="%(ResolvedFileToPublish.FullPath)" />
     </ItemGroup>
   </Target>