Skip to content

Update maintenance-packages versions #114281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2025
Merged

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Apr 4, 2025

dotnet/dotnet PR: https://github.com/dotnet/dotnet/pull/155/files

Updating:

  • System.Memory to 4.6.3
  • System.Runtime.CompilerServices.Unsafe to 6.1.2
  • System.Threading.Tasks.Extensions to 4.6.3

Prebuilts PRs needed merged first and flowing here:

@carlossanlop carlossanlop requested review from ViktorHofer, ericstj and a team April 4, 2025 19:10
@carlossanlop carlossanlop self-assigned this Apr 4, 2025
@Copilot Copilot AI review requested due to automatic review settings April 4, 2025 19:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • eng/Versions.props: Language not supported

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

…ence-packages build 20250404.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.617601 -> To Version 10.0.620402
@carlossanlop
Copy link
Contributor Author

Here's the prebuilts deps flow: #114283 (review)

…5-a5c838a0e367' into UpdateMP2

[main] Update dependencies from dotnet/source-build-reference-packages
@ericstj
Copy link
Member

ericstj commented Apr 4, 2025

Mac build failing due to #114235, #114248, fix is #114277.

@carlossanlop
Copy link
Contributor Author

The linux arm64 NativeAOT failure was a Reflection test says an assembly could not be loaded.

[FAIL] System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName
System.IO.FileLoadException : The given assembly name was invalid.
   at System.Reflection.Metadata.TypeNameParser.ParseNextTypeName(Boolean, Int32&) + 0x494
   at System.Reflection.Metadata.TypeNameParser.Parse(ReadOnlySpan`1, Boolean, Nullable`1) + 0x54
   at System.Reflection.TypeNameResolver.GetType(String, Boolean, Boolean, Assembly) + 0x60
   at System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName() + 0x1a8
   at System.Reflection!<BaseAddress>+0x1529744
   at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0x10c
[FAIL] System.Reflection.Tests.GetTypeTests.GetType_CoreAssembly
System.IO.FileLoadException : The given assembly name was invalid.
   at System.Reflection.Metadata.TypeNameParser.ParseNextTypeName(Boolean, Int32&) + 0x494
   at System.Reflection.Metadata.TypeNameParser.Parse(ReadOnlySpan`1, Boolean, Nullable`1) + 0x54
   at System.Reflection.TypeNameResolver.GetType(String, Boolean, Boolean, Assembly) + 0x60
   at System.Reflection.Tests.GetTypeTests.GetType_CoreAssembly() + 0x188
   at System.Reflection!<BaseAddress>+0x1529744
   at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0x10c
[SKIP] System.Reflection.Tests.GetTypeTests.TestTypeIdentifierAttribute
[SKIP] System.Reflection.Tests.GetTypeTests.TypeNamesThatRequireEscaping
[SKIP] System.Reflection.Tests.AssemblyNameTests.EmptyFusionLog
[SKIP] System.Reflection.Tests.MemberInfoTests.HasSameMetadataDefinitionAs_CornerCase_CLSIDConstructor
Finished System.Reflection.Tests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51

@carlossanlop
Copy link
Contributor Author

carlossanlop commented Apr 4, 2025

It's also happening in Windows arm64 NativeAOT:

[FAIL] System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName
System.IO.FileLoadException : The given assembly name was invalid.
   at System.Reflection.Metadata.TypeNameParser.ParseNextTypeName(Boolean, Int32&) + 0x494
   at System.Reflection.Metadata.TypeNameParser.Parse(ReadOnlySpan`1, Boolean, Nullable`1) + 0x54
   at System.Reflection.TypeNameResolver.GetType(String, Boolean, Boolean, Assembly) + 0x60
   at System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName() + 0x1a8
   at System.Reflection.Tests!<BaseAddress>+0x979754
   at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0x10c
[FAIL] System.Reflection.Tests.GetTypeTests.GetType_CoreAssembly
System.IO.FileLoadException : The given assembly name was invalid.
   at System.Reflection.Metadata.TypeNameParser.ParseNextTypeName(Boolean, Int32&) + 0x494
   at System.Reflection.Metadata.TypeNameParser.Parse(ReadOnlySpan`1, Boolean, Nullable`1) + 0x54
   at System.Reflection.TypeNameResolver.GetType(String, Boolean, Boolean, Assembly) + 0x60
   at System.Reflection.Tests.GetTypeTests.GetType_CoreAssembly() + 0x188
   at System.Reflection.Tests!<BaseAddress>+0x979754
   at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0x10c
[SKIP] System.Reflection.Tests.GetTypeTests.TestTypeIdentifierAttribute
[SKIP] System.Reflection.Tests.GetTypeTests.TypeNamesThatRequireEscaping
[SKIP] System.Reflection.Tests.FieldInfoTests.GetValueFromRvaField
[SKIP] System.Reflection.Tests.AssemblyNameTests.EmptyFusionLog
[SKIP] System.Reflection.Tests.MemberInfoTests.HasSameMetadataDefinitionAs_CornerCase_CLSIDConstructor
Finished System.Reflection.Tests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51

@agocke
Copy link
Member

agocke commented Apr 4, 2025

These packages are unused on .NET Core right? They're just empty facades?

@carlossanlop
Copy link
Contributor Author

These packages are unused on .NET Core right? They're just empty facades?

They're only needed for .NET Framework.

@ericstj
Copy link
Member

ericstj commented Apr 4, 2025

Failures are caused by #114228 -- we'll need a new known issue.

@carlossanlop
Copy link
Contributor Author

we'll need a new known issue.

Done #114288 cc @adamsitnik

@ericstj
Copy link
Member

ericstj commented Apr 5, 2025

/ba-g - All Test Errors are known - osx build failure mentioned above, WASM timeout was seen elsewhere like #112937 -- see https://dev.azure.com/dnceng-public/public/_build/results?buildId=1005987&view=logs&j=d4e38924-13a0-58bd-9074-6a4810543e7c&t=102a6595-1420-53fc-8f17-b0a3f4b1242a&l=1 @akoeplinger suspect that we have a leak in one of the tools run in WASM that's consuming memory and causing builds to fail in interesting ways (OOM killer, restart, lost connection)

@carlossanlop carlossanlop deleted the UpdateMP2 branch April 5, 2025 18:12
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants