Skip to content

NativeAOT failure in System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName #114288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carlossanlop opened this issue Apr 4, 2025 · 4 comments · Fixed by #114289
Closed
Labels
area-NativeAOT-coreclr Known Build Error Use this to report build issues in the .NET Helix tab

Comments

@carlossanlop
Copy link
Contributor

carlossanlop commented Apr 4, 2025

@adamsitnik Regression introduced by #114228

Build Information

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1005987
Build error leg or test failing: All NativeAOT legs

Error Message

{
  "ErrorMessage" : ["System.Reflection.Tests.GetTypeTests", "System.IO.FileLoadException : The given assembly name was invalid"],
  "BuildRetry" : false,
  "ExcludeConsoleLog" : false
}
[FAIL] System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName
System.IO.FileLoadException : The given assembly name was invalid.
   at System.Reflection.Metadata.TypeNameParser.ParseNextTypeName(Boolean, Int32&) + 0x494
   at System.Reflection.Metadata.TypeNameParser.Parse(ReadOnlySpan`1, Boolean, Nullable`1) + 0x54
   at System.Reflection.TypeNameResolver.GetType(String, Boolean, Boolean, Assembly) + 0x60
   at System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName() + 0x1a8
   at System.Reflection!<BaseAddress>+0x1529744
   at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0x10c
[FAIL] System.Reflection.Tests.GetTypeTests.GetType_CoreAssembly
System.IO.FileLoadException : The given assembly name was invalid.
   at System.Reflection.Metadata.TypeNameParser.ParseNextTypeName(Boolean, Int32&) + 0x494
   at System.Reflection.Metadata.TypeNameParser.Parse(ReadOnlySpan`1, Boolean, Nullable`1) + 0x54
   at System.Reflection.TypeNameResolver.GetType(String, Boolean, Boolean, Assembly) + 0x60
   at System.Reflection.Tests.GetTypeTests.GetType_CoreAssembly() + 0x188
   at System.Reflection!<BaseAddress>+0x1529744
   at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0x10c
[SKIP] System.Reflection.Tests.GetTypeTests.TestTypeIdentifierAttribute
[SKIP] System.Reflection.Tests.GetTypeTests.TypeNamesThatRequireEscaping
[SKIP] System.Reflection.Tests.AssemblyNameTests.EmptyFusionLog
[SKIP] System.Reflection.Tests.MemberInfoTests.HasSameMetadataDefinitionAs_CornerCase_CLSIDConstructor
Finished System.Reflection.Tests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=1005987
Error message validated: [System.IO.FileLoadException : The given assembly name was invalid]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/4/2025 11:12:12 PM UTC

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=1005987
Error message validated: [System.Reflection.Tests.GetTypeTests System.IO.FileLoadException : The given assembly name was invalid]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/4/2025 11:16:11 PM UTC

Report

Build Definition Test Pull Request
1006085 dotnet/runtime System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName #114246
1006068 dotnet/runtime System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName #114282
1005987 dotnet/runtime System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName #114281
1005976 dotnet/runtime System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName #114284
1005973 dotnet/runtime System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName #114187

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
5 5 5
@carlossanlop carlossanlop added area-NativeAOT-coreclr Known Build Error Use this to report build issues in the .NET Helix tab labels Apr 4, 2025
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 4, 2025
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Apr 4, 2025

Ah, I am sorry - I have missed this failure in the list of other known failures.

@ericstj
Copy link
Member

ericstj commented Apr 4, 2025

Easy to do right now - lots of red.

@carlossanlop
Copy link
Contributor Author

I forgive you, @jkotas

jkotas added a commit to jkotas/runtime that referenced this issue Apr 4, 2025
…semblyName

Apply the fix to NativeAOT TypeNameResolver too

Fixes dotnet#114288
@jkotas jkotas closed this as completed in 5854863 Apr 5, 2025
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Apr 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr Known Build Error Use this to report build issues in the .NET Helix tab
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants