-
Notifications
You must be signed in to change notification settings - Fork 5k
Document NDK upgrade process #112885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Document NDK upgrade process #112885
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6e0b09f
Describe NDK upgrade process
jkurdek c2aa783
Improve documentation
jkurdek 0529da4
Fix numbering
jkurdek 65cdfad
Add additional context requested in PR review
jkurdek 1f5d807
Improve description
jkurdek c11a616
Merge branch 'main' into doc-ndk-upgrade
jkurdek a05abde
Merge branch 'main' into doc-ndk-upgrade
jkurdek 822b5b5
Merge branch 'main' into doc-ndk-upgrade
vitek-karas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update our codespaces container definition? (I can do it, just want to make sure its the right thing to do)
runtime/.devcontainer/android/Dockerfile
Line 31 in 2a19c9d
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we should update the codespaces, we have upgraded the NDK version to 27c on the CI. This is also true about .NET 9.