Document NDK upgrade process #112885
Document NDK upgrade process #112885
Conversation
jkurdek
added
the
documentation
ghost
added
the
needs-area-label
| @@ -22,7 +22,7 @@ Android SDK and NDK can be automatically installed via the following script: | |||
| #!/usr/bin/env bash | |||
| set -e | |||
|
|
|||
| NDK_VER=r23c | |||
| NDK_VER=r27c | |||
There was a problem hiding this comment.
Should we update our codespaces container definition? (I can do it, just want to make sure its the right thing to do)
runtime/.devcontainer/android/Dockerfile
Line 31 in 2a19c9d
There was a problem hiding this comment.
Yes we should update the codespaces, we have upgraded the NDK version to 27c on the CI. This is also true about .NET 9.
|
|
||
| The Android NDK LTS version is released annually. CI pipelines retrieve the NDK version from Docker images hosted in the [dotnet-buildtools-prereqs-docker](https://github.com/dotnet/dotnet-buildtools-prereqs-docker) repository. | ||
| For reference, see an example Dockerfile: | ||
| [Azure Linux 3.0 .NET 10.0 Android Dockerfile](https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/src/azurelinux/3.0/net10.0/android/amd64/Dockerfile). |
There was a problem hiding this comment.
Best to use sha-specific links.
| - Ensure **AOT** and **AOT_WITH_LIBRARY_FILES** are enabled in the build. | ||
|
|
||
| ### 2. Test the New NDK in CI and Fix Issues | ||
| - Create a new Docker image containing the updated NDK version. |
There was a problem hiding this comment.
This seems to be missing some important steps. How does that related to the prereqs repo?
There was a problem hiding this comment.
Bumping version of the NDK in the prereqs repo will automatically propagate it to all CI runs. What we need is a mechanism of verifying that bumping the NDK will not break the CI before doing that. Since NDK version is defined in a separate repo this becomes a bit messy.
There are several ways of doing this:
- Create a mock image based on the one coming from prereqs and run another PR to test the CI (CI is verified in a separate PR which is not ideal)
- Create a new image in prereqs repo and update the reference to it on runtime side (change is verified in the same PR but now we need to create a new image every time we bump a dependency)
- Modify the original image to have multiple NDK versions and in the runtime PR change the env variable to point to the new one, remove the old NDK version after the runtime change is verified. (A lot of modifications for one change)
There was a problem hiding this comment.
Do you mean "new" or "existing" image? Your response seems to suggest "existing". How do you know that you've updated all of them?
We're having that same discussion here: dotnet/dotnet-buildtools-prereqs-docker#1371
|
|
||
| ## Upgrading the Android NDK Version in CI Pipelines | ||
|
|
||
| The Android NDK LTS version is released annually. CI pipelines retrieve the NDK version from Docker images hosted in the [dotnet-buildtools-prereqs-docker](https://github.com/dotnet/dotnet-buildtools-prereqs-docker) repository. |
There was a problem hiding this comment.
It would be good to cover:
- Which month (or quarter) we expect this in and if adopting RCs is important.
- What we need to do in
mainvsrelease/and if the MAUI support timeframe gives us a degree of freedom inrelease/.
am11
added
area-Meta
os-android
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-meta |
|
/ba-g markdown change, skipped pipelines |
The PR documents the process of upgrading the NDK on runtime CI.