Fix failure in System.Reflection.Tests.GetTypeTests.GetType_InvalidAssemblyName #114289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…semblyName Apply the fix to NativeAOT TypeNameResolver too Fixes dotnet#114288
ghost
added
the
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/TypeNameResolver.NativeAot.cs:84
- Verify that removing the check for topLevelAssembly is intentional. With this change, if topLevelAssembly is null but parsed.AssemblyName is present, an exception will be thrown, which may differ from previous behavior.
else if (parsed.AssemblyName is not null)
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
lewing
approved these changes
Apr 5, 2025
|
@jkotas thank you for providing the fix ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the fix to NativeAOT TypeNameResolver too
Fixes #114288