Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to release nuget packages #77261

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Update to release nuget packages #77261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e36c96
Update to release nuget packages
333fred Feb 18, 2025
b51fe43
Skip tests for https://github.com/microsoft/vs-solutionpersistence/is…
333fred Feb 18, 2025
3134b36
Skip failing tests, see https://github.com/dotnet/roslyn/issues/77293.
333fred Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions eng/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<_BasicReferenceAssembliesVersion>1.7.9</_BasicReferenceAssembliesVersion>
<!-- CodeStyleAnalyzerVersion should we updated together with version of dotnet-format in dotnet-tools.json -->
<CodeStyleAnalyzerVersion>4.8.0-3.final</CodeStyleAnalyzerVersion>
<VisualStudioEditorPackagesVersion>17.12.145-preview</VisualStudioEditorPackagesVersion>
<VisualStudioEditorPackagesVersion>17.13.226</VisualStudioEditorPackagesVersion>
<ILAsmPackageVersion>9.0.0-rc.2.24462.10</ILAsmPackageVersion>
<ILDAsmPackageVersion>6.0.0-rtm.21518.12</ILDAsmPackageVersion>
<MicrosoftILVerificationVersion>7.0.0-alpha.1.22060.1</MicrosoftILVerificationVersion>
Expand Down Expand Up @@ -45,10 +45,10 @@
</ItemGroup>

<ItemGroup Condition="'$(DotNetBuildSourceOnly)' != 'true' and '$(TargetFramework)' == 'net472'">
<PackageVersion Include="Microsoft.Build" Version="17.12.0-preview-24426-07" />
<PackageVersion Include="Microsoft.Build.Framework" Version="17.12.0-preview-24426-07" />
<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.12.0-preview-24426-07" />
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="17.12.0-preview-24426-07" />
<PackageVersion Include="Microsoft.Build" Version="17.13.9" />
<PackageVersion Include="Microsoft.Build.Framework" Version="17.13.9" />
<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.13.9" />
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="17.13.9" />
</ItemGroup>

<ItemGroup>
Expand All @@ -57,10 +57,10 @@
<!--
Visual Studio
-->
<PackageVersion Include="Microsoft.VisualStudio.SDK" Version="17.12.39557-preview.2.1" />
<PackageVersion Include="Microsoft.VisualStudio.SDK" Version="17.13.40008" />
<PackageVersion Include="Microsoft.Internal.VisualStudio.Shell.Framework" Version="17.9.36524" />
<PackageVersion Include="Microsoft.ServiceHub.Client" Version="4.2.1017" />
<PackageVersion Include="Microsoft.VisualStudio.Extensibility.Sdk" Version="17.12.39557-preview.2.1" />
<PackageVersion Include="Microsoft.VisualStudio.Extensibility.Sdk" Version="17.13.40008" />
<PackageVersion Include="Microsoft.VisualStudio.Extensibility" Version="17.12.2037-preview3" />
<PackageVersion Include="Microsoft.VisualStudio.Extensibility.JsonGenerators.Sdk" Version="17.12.2037-preview3" />
<PackageVersion Include="Microsoft.VSSDK.Debugger.VSDConfigTool" Version="17.13.1100801-preview" />
Expand Down Expand Up @@ -92,31 +92,31 @@
Subset of Microsoft.VisualStudio.Sdk meta-package (run `csi generate-vssdk-versions.csx` to update based on VSSDK meta-package).
See https://github.com/dotnet/arcade/blob/main/Documentation/MirroringPackages.md if any of these packages fail to restore.
-->
<PackageVersion Include="Microsoft.ServiceHub.Framework" Version="4.7.32-beta" />
<PackageVersion Include="Microsoft.VisualStudio.Composition" Version="17.12.17-preview" />
<PackageVersion Include="Microsoft.VisualStudio.Composition.Analyzers" Version="17.12.17-preview" />
<PackageVersion Include="Microsoft.VisualStudio.CoreUtility" Version="17.12.145-preview" />
<PackageVersion Include="Microsoft.VisualStudio.Editor" Version="17.12.145-preview" />
<PackageVersion Include="Microsoft.VisualStudio.ImageCatalog" Version="17.12.39557-preview.2.1" />
<PackageVersion Include="Microsoft.VisualStudio.Imaging.Interop.14.0.DesignTime" Version="17.12.39557-preview.2.1" />
<PackageVersion Include="Microsoft.VisualStudio.Language" Version="17.12.145-preview" />
<PackageVersion Include="Microsoft.VisualStudio.Language.NavigateTo.Interfaces" Version="17.12.145-preview" />
<PackageVersion Include="Microsoft.VisualStudio.Language.StandardClassification" Version="17.12.145-preview" />
<PackageVersion Include="Microsoft.VisualStudio.LanguageServer.Client" Version="17.12.39-preview" />
<PackageVersion Include="Microsoft.ServiceHub.Framework" Version="4.8.3" />
<PackageVersion Include="Microsoft.VisualStudio.Composition" Version="17.12.20" />
<PackageVersion Include="Microsoft.VisualStudio.Composition.Analyzers" Version="17.12.20" />
<PackageVersion Include="Microsoft.VisualStudio.CoreUtility" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.Editor" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.ImageCatalog" Version="17.13.40008" />
<PackageVersion Include="Microsoft.VisualStudio.Imaging.Interop.14.0.DesignTime" Version="17.13.40008" />
<PackageVersion Include="Microsoft.VisualStudio.Language" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.Language.NavigateTo.Interfaces" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.Language.StandardClassification" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.LanguageServer.Client" Version="17.13.33" />
<PackageVersion Include="Microsoft.VisualStudio.RemoteControl" Version="16.3.52" />
<PackageVersion Include="Microsoft.VisualStudio.RpcContracts" Version="17.12.11-preview" />
<PackageVersion Include="Microsoft.VisualStudio.Shell.15.0" Version="17.12.39557-preview.2.1" />
<PackageVersion Include="Microsoft.VisualStudio.RpcContracts" Version="17.13.7" />
<PackageVersion Include="Microsoft.VisualStudio.Shell.15.0" Version="17.13.40008" />
<PackageVersion Include="Microsoft.VisualStudio.Telemetry" Version="17.14.2" />
<PackageVersion Include="Microsoft.VisualStudio.Text.Data" Version="17.12.145-preview" />
<PackageVersion Include="Microsoft.VisualStudio.Text.Logic" Version="17.12.145-preview" />
<PackageVersion Include="Microsoft.VisualStudio.Text.UI" Version="17.12.145-preview" />
<PackageVersion Include="Microsoft.VisualStudio.Text.UI.Wpf" Version="17.12.145-preview" />
<PackageVersion Include="Microsoft.VisualStudio.Threading" Version="17.12.13-preview" />
<PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.12.13-preview" />
<PackageVersion Include="Microsoft.VisualStudio.Text.Data" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.Text.Logic" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.Text.UI" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.Text.UI.Wpf" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.Threading" Version="17.13.2" />
<PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.13.2" />
<PackageVersion Include="Microsoft.VisualStudio.Utilities.Internal" Version="16.3.90" />
<PackageVersion Include="Nerdbank.Streams" Version="2.11.79" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="StreamJsonRpc" Version="2.20.8-beta" />
<PackageVersion Include="StreamJsonRpc" Version="2.21.10" />

<!--
VS Debugger
Expand Down Expand Up @@ -254,7 +254,7 @@
<PackageVersion Include="Microsoft.VisualStudio.Extensibility.Testing.SourceGenerator" Version="$(MicrosoftVisualStudioExtensibilityTestingVersion)" />
<PackageVersion Include="Microsoft.VisualStudio.Extensibility.Testing.Xunit" Version="$(MicrosoftVisualStudioExtensibilityTestingVersion)" />
<PackageVersion Include="System.Management" Version="7.0.0" />
<PackageVersion Include="System.Drawing.Common" Version="8.0.0" />
<PackageVersion Include="System.Drawing.Common" Version="8.0.8" />
<PackageVersion Include="NuGet.SolutionRestoreManager.Interop" Version="4.8.0" />
<PackageVersion Include="Moq" Version="4.10.1" />
<PackageVersion Include="System.CodeDom" Version="7.0.0" />
Expand Down
4 changes: 3 additions & 1 deletion src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpGoToImplementation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,9 @@ await TestServices.Editor.SetTextAsync(
}

[IdeTheory]
[CombinatorialData]
//[CombinatorialData]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either delete this or add a comment to go back to CombinatorialData when the skip is removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also suspicious as everything that one side would work and the other side would not, so if you just want to skip both I'm OK with that.

[InlineData(false, Skip = "https://github.com/dotnet/roslyn/issues/77293")]
[InlineData(true)]
public async Task GoToImplementationFromMetadataAsSource(bool asyncNavigation)
{
await TestServices.Editor.ConfigureAsyncNavigation(asyncNavigation ? AsyncNavigationKind.Asynchronous : AsyncNavigationKind.Synchronous, HangMitigatingCancellationToken);
Expand Down
8 changes: 4 additions & 4 deletions src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpWinForms.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ private void ExecuteWhenButtonClicked(object sender, EventArgs e)
}", codeFileActualText);
}

[IdeFact]
[IdeFact(Skip = "https://github.com/dotnet/roslyn/issues/77293")]
public async Task RenameControl()
{
var project = ProjectName;
Expand Down Expand Up @@ -146,7 +146,7 @@ await TestServices.Workspace.WaitForAllAsyncOperationsAsync(
Assert.DoesNotContain(@"private System.Windows.Forms.Button SomeButton;", actualText);
}

[IdeFact]
[IdeFact(Skip = "https://github.com/dotnet/roslyn/issues/77293")]
public async Task RemoveEventHandler()
{
var project = ProjectName;
Expand Down Expand Up @@ -176,7 +176,7 @@ await TestServices.Workspace.WaitForAllAsyncOperationsAsync(
Assert.DoesNotContain(@"VisualStudio.Editor.SomeButton.Click += new System.EventHandler(VisualStudio.Editor.GooHandler);", actualText);
}

[IdeFact]
[IdeFact(Skip = "https://github.com/dotnet/roslyn/issues/77293")]
public async Task ChangeAccessibility()
{
var project = ProjectName;
Expand Down Expand Up @@ -205,7 +205,7 @@ await TestServices.Workspace.WaitForAllAsyncOperationsAsync(
var actualText = await TestServices.Editor.GetTextAsync(HangMitigatingCancellationToken);
Assert.Contains(@"public System.Windows.Forms.Button SomeButton;", actualText);
}
[IdeFact]
[IdeFact(Skip = "https://github.com/dotnet/roslyn/issues/77293")]
public async Task DeleteControl()
{
if (ExecutionConditionUtil.IsBitness64)
Expand Down
6 changes: 3 additions & 3 deletions src/Workspaces/MSBuildTest/VisualStudioMSBuildWorkspaceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ private static MetadataReference GetMetadataReferenceByAlias(Project project, st
private static Metadata GetMetadata(MetadataReference metadataReference)
=> ((PortableExecutableReference)metadataReference).GetMetadata();

[ConditionalFact(typeof(VisualStudioMSBuildInstalled))]
[ConditionalFact(typeof(VisualStudioMSBuildInstalled), AlwaysSkip = "https://github.com/microsoft/vs-solutionpersistence/issues/95")]
[WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/552981")]
public async Task TestOpenSolution_DuplicateProjectGuids()
{
Expand Down Expand Up @@ -2708,7 +2708,7 @@ public async Task TestOpenSolution_SolutionFileHasMissingEndProject()
}
}

[ConditionalFact(typeof(VisualStudioMSBuildInstalled))]
[ConditionalFact(typeof(VisualStudioMSBuildInstalled), AlwaysSkip = "https://github.com/microsoft/vs-solutionpersistence/issues/95")]
[WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/792912")]
public async Task TestOpenSolution_WithDuplicatedGuidsBecomeSelfReferential()
{
Expand All @@ -2734,7 +2734,7 @@ public async Task TestOpenSolution_WithDuplicatedGuidsBecomeSelfReferential()
Assert.Empty(libraryProject.AllProjectReferences);
}

[ConditionalFact(typeof(VisualStudioMSBuildInstalled))]
[ConditionalFact(typeof(VisualStudioMSBuildInstalled), AlwaysSkip = "https://github.com/microsoft/vs-solutionpersistence/issues/95")]
[WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/792912")]
public async Task TestOpenSolution_WithDuplicatedGuidsBecomeCircularReferential()
{
Expand Down