Update to release nuget packages #77261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to publish 17.13 nuget packages, we need to update a few dependencies. I updated the minimum number of packages required from our public packages, then fixed up any restore issues. For each updated package, I then went and confirmed that the dll was actually present in 17.13.0, so we should be safe from dependency loading issues. This change does not need to be inserted into VS.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
jasonmalinowski
approved these changes
Feb 18, 2025
JoeRobich
approved these changes
Feb 18, 2025
jasonmalinowski
approved these changes
Feb 19, 2025
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -111,7 +111,9 @@ await TestServices.Editor.SetTextAsync( | |||
| } | |||
|
|
|||
| [IdeTheory] | |||
| [CombinatorialData] | |||
| //[CombinatorialData] | |||
There was a problem hiding this comment.
Either delete this or add a comment to go back to CombinatorialData when the skip is removed.
There was a problem hiding this comment.
It's also suspicious as everything that one side would work and the other side would not, so if you just want to skip both I'm OK with that.
jasonmalinowski
approved these changes
Feb 20, 2025
| @@ -111,7 +111,9 @@ await TestServices.Editor.SetTextAsync( | |||
| } | |||
|
|
|||
| [IdeTheory] | |||
| [CombinatorialData] | |||
| //[CombinatorialData] | |||
There was a problem hiding this comment.
It's also suspicious as everything that one side would work and the other side would not, so if you just want to skip both I'm OK with that.
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Feb 20, 2025
* Update to release nuget packages In order to publish 17.13 nuget packages, we need to update a few dependencies. I updated the minimum number of packages required from our public packages, then fixed up any restore issues. For each updated package, I then went and confirmed that the dll was actually present in 17.13.0, so we should be safe from dependency loading issues. This change does not need to be inserted into VS. * Skip tests for microsoft/vs-solutionpersistence#95 * Skip failing tests, see dotnet#77293. (cherry picked from commit 3350036)
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Feb 20, 2025
* Update to release nuget packages In order to publish 17.13 nuget packages, we need to update a few dependencies. I updated the minimum number of packages required from our public packages, then fixed up any restore issues. For each updated package, I then went and confirmed that the dll was actually present in 17.13.0, so we should be safe from dependency loading issues. This change does not need to be inserted into VS. * Skip tests for microsoft/vs-solutionpersistence#95 * Skip failing tests, see dotnet#77293. (cherry picked from commit 3350036)
333fred
added a commit
that referenced
this pull request
Feb 20, 2025
* Update to release nuget packages In order to publish 17.13 nuget packages, we need to update a few dependencies. I updated the minimum number of packages required from our public packages, then fixed up any restore issues. For each updated package, I then went and confirmed that the dll was actually present in 17.13.0, so we should be safe from dependency loading issues. This change does not need to be inserted into VS. * Skip tests for microsoft/vs-solutionpersistence#95 * Skip failing tests, see #77293. (cherry picked from commit 3350036)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to publish 17.13 nuget packages, we need to update a few dependencies. I updated the minimum number of packages required from our public packages, then fixed up any restore issues. For each updated package, I then went and confirmed that the dll was actually present in 17.13.0, so we should be safe from dependency loading issues. This change does not need to be inserted into VS.