Skip to content

[NO MERGE] check if new version of BDN supports .NET Core 5.0 #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[NO MERGE] check if new version of BDN supports .NET Core 5.0 #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bfe116
check if new version of BDN supports .NET Core 5.0
adamsitnik Aug 10, 2019
74edc53
this method is now public
adamsitnik Aug 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ jobs:
csproj: src\benchmarks\micro\MicroBenchmarks.csproj
runCategories: 'coreclr corefx'
frameworks: # for public jobs we want to make sure that the PRs don't break any of the supported frameworks
- netcoreapp5.0
- netcoreapp3.0
- netcoreapp2.2
- netcoreapp2.1
Expand Down Expand Up @@ -82,7 +83,7 @@ jobs:
csproj: src\benchmarks\micro\MicroBenchmarks.csproj
runCategories: 'coreclr corefx'
frameworks: # for public jobs we want to make sure that the PRs don't break x86
- netcoreapp3.0
- netcoreapp5.0

# Windows x64 micro benchmarks, private job
- ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
Expand Down Expand Up @@ -130,6 +131,7 @@ jobs:
csproj: src/benchmarks/micro/MicroBenchmarks.csproj
runCategories: 'coreclr corefx'
frameworks: # for public jobs we want to make sure that the PRs don't break any of the supported frameworks
- netcoreapp5.0
- netcoreapp3.0
- netcoreapp2.2
- netcoreapp2.1
Expand Down
4 changes: 2 additions & 2 deletions src/harness/BenchmarkDotNet.Extensions/BenchmarkDotNet.Extensions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="BenchmarkDotNet" Version="0.11.3.1003" />
<PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.11.3.1003" />
<PackageReference Include="BenchmarkDotNet" Version="0.11.5.1137" />
<PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.11.5.1137" />
</ItemGroup>

<ItemGroup>
Expand Down
6 changes: 1 addition & 5 deletions src/harness/BenchmarkDotNet.Extensions/PerfLabExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,10 @@ public override void ExportToLog(Summary summary, ILogger logger)
if (reporter == null) // not running in the perf lab
return;

var nameDelegate = typeof(BenchmarkCase).Assembly.GetType("BenchmarkDotNet.Exporters.FullNameProvider").GetMethod("GetBenchmarkName", BindingFlags.Static | BindingFlags.NonPublic);


foreach (var report in summary.Reports)
{
var test = new Test();
//test.Name = FullNameProvider.GetBenchmarkName(report.BenchmarkCase);
test.Name = (string)nameDelegate.Invoke(null, new[] { report.BenchmarkCase });
test.Name = FullNameProvider.GetBenchmarkName(report.BenchmarkCase);
test.Categories = report.BenchmarkCase.Descriptor.Categories;
var results = from result in report.AllMeasurements
where result.IterationMode == Engines.IterationMode.Workload && result.IterationStage == Engines.IterationStage.Result
Expand Down