Skip to content

[NO MERGE] check if new version of BDN supports .NET Core 5.0 #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

adamsitnik
Copy link
Member

The purpose of this PR is to check if the new version of BDN supports .NET Core 5.0 and everything works as expected.

/cc @adiaaida @billwert

@michellemcdaniel
Copy link
Contributor

Looks like everything checked out. So if you want to change this from a draft to a real PR, looks good to me.

@billwert
Copy link
Contributor

@adamsitnik did we figure out the remaining diffs?

@billwert
Copy link
Contributor

@adamsitnik I see now that this build probably is the CI job for dotnet/BenchmarkDotNet#1188. I am curious if there's a path where BDN can be more accepting to TFMs it doesn't know about, in line with the robustness principle. While I agree that we should be updating BDN with some frequency, I would very much like to never be broken in this manner again.

@michellemcdaniel
Copy link
Contributor

I just want to note that getting an update to BDN that supports netcoreapp5.0 is blocking our ability to run per-commit builds in coreclr and corefx (a fact that I just realized while talking to Jarret). So if we can up the priority on figuring out why we're seeing the weird performance impact in your other PR, and get a stable version of BDN that supports netcoreapp5.0, that would be great!

@michellemcdaniel
Copy link
Contributor

Thought: could we conditionalize the package reference for netcoreapp5.0 so that we could get that working without affecting any of the earlier releases until we understand the performance differences we saw? We've already switched to the tigers from the snakes, so there's already a break in our graphs, and this seems like a good time to make that switch.

@billwert @adamsitnik

@adamsitnik
Copy link
Member Author

I've updated #511 so I am closing this one

@adamsitnik adamsitnik closed this Aug 14, 2019
@adamsitnik adamsitnik deleted the tryNetCoreApp50BdnSupport branch August 15, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants