Skip to content

Update to clang 20.1.0 #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Update to clang 20.1.0 #1369

merged 3 commits into from
Mar 7, 2025

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Feb 21, 2025

See dotnet/runtime#109939 (comment). The ppc64le build break has been fixed: dotnet/runtime#112777.

@sbomer sbomer requested a review from richlander February 21, 2025 17:52
@sbomer sbomer requested review from a team as code owners February 21, 2025 17:52
@jkoritzinsky
Copy link
Member

We should update the version in the optimization images as well.

@richlander
Copy link
Member

I'm assuming we will not merge this change until we do a test run. We need confidence that we will not break CI, particularly since one break has already been found.

@jkotas

@am11
Copy link
Member

am11 commented Feb 24, 2025

In the past, we have waited for the official release (and sometimes for update 2; which gives them enough time to fix major issues with the release). llvm 20.0 is scheduled for Mar 11th and 20.1 two weeks after that. Can this not wait?

@richlander
Copy link
Member

richlander commented Feb 24, 2025

We could wait. What concerns do you have about "major issues"? Do you think the issues might block us shipping a preview?

It's also a question of whether we want to help finding those issues. I think that would be useful to the community.

@am11
Copy link
Member

am11 commented Feb 24, 2025

We could wait. What concerns do you have about "major issues"? Do you think the issues might block us shipping a preview?

In the first few weeks after the release, they usually prioritize fixing and backporting bugfixes discovered by large consumer base (most folks do not test the release candidate branches). Empirically speaking, the .1, .2 llvm-toolchain releases are usually more stable than RTM (just like .NET).

https://github.com/llvm/llvm-project/issues?q=is:issue%20is:closed%20label:regression:19

It's also a question of whether we want to help finding those issues. I think that would be useful to the community.

I think it is a good plan. We can update it during RC period each year.

@sbomer sbomer changed the title Update to clang 20.1.0-rc2 Update to clang 20.1.0 Mar 6, 2025
@sbomer sbomer merged commit eb9fb62 into dotnet:main Mar 7, 2025
16 checks passed
@richlander
Copy link
Member

Focusing on RC was an elaborate ploy to get us to adopt the GA release week-of!

@richlander
Copy link
Member

Thanks @sbomer!

@am11
Copy link
Member

am11 commented Mar 7, 2025

BTW, new images are not built because the heuristics aren't perfect. We would need to touch crossdeps-llvm etc. or someone will need to manually evict the cache in ACR #1312.

@mthalman
Copy link
Member

mthalman commented Mar 7, 2025

I'll kick the build to disable caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants