-
Notifications
You must be signed in to change notification settings - Fork 116
Update to clang 20.1.0 #1369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to clang 20.1.0 #1369
Conversation
We should update the version in the optimization images as well. |
I'm assuming we will not merge this change until we do a test run. We need confidence that we will not break CI, particularly since one break has already been found. |
In the past, we have waited for the official release (and sometimes for update 2; which gives them enough time to fix major issues with the release). llvm 20.0 is scheduled for Mar 11th and 20.1 two weeks after that. Can this not wait? |
We could wait. What concerns do you have about "major issues"? Do you think the issues might block us shipping a preview? It's also a question of whether we want to help finding those issues. I think that would be useful to the community. |
In the first few weeks after the release, they usually prioritize fixing and backporting bugfixes discovered by large consumer base (most folks do not test the release candidate branches). Empirically speaking, the .1, .2 llvm-toolchain releases are usually more stable than RTM (just like .NET). https://github.com/llvm/llvm-project/issues?q=is:issue%20is:closed%20label:regression:19
I think it is a good plan. We can update it during RC period each year. |
Focusing on RC was an elaborate ploy to get us to adopt the GA release week-of! |
Thanks @sbomer! |
BTW, new images are not built because the heuristics aren't perfect. We would need to touch |
I'll kick the build to disable caching. |
See dotnet/runtime#109939 (comment). The ppc64le build break has been fixed: dotnet/runtime#112777.