Add SHAs to image references #113180
Closed
Add SHAs to image references #113180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
There was a problem hiding this comment.
PR Overview
This PR pre-pins image references by appending specific SHA256 checksums to ensure CI stability.
- Append SHA256 digest for Browser wasm image
- Append SHA256 digest for Linux arm, arm64, and musl variants
Reviewed Changes
| File | Description |
|---|---|
| eng/pipelines/coreclr/templates/helix-queues-setup.yml | Added SHA256 digests to image references for multiple platforms |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
eng/pipelines/coreclr/templates/helix-queues-setup.yml:72
- The image reference 'Ubuntu.2204.Armarch.Open' on the public branch has inconsistent capitalization compared to the internal branch version ('Ubuntu.2204.ArmArch'). Verify if this inconsistency is intentional or should be standardized.
- - (Ubuntu.2204.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-22.04-helix-arm64v8@sha256:178cddec52073409ad7e4cb7730fec867391bf6172ac9297981f183bd5808e7d
sbomer
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Thank you! We need to update the references to the build images in https://github.com/dotnet/runtime/blob/main/eng/pipelines/common/templates/pipeline-with-resources.yml. I think the helix references can stay unpinned since they don't depend on llvm.
|
Sorry. That was silly! Will do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pre-pin these references to ensure that don't break CI.