Remove helix script install (partial set of Dockerfiles) #1336
Conversation
|
@dougbu - It would be good for you to review these changes. |
|
@MichaelSimons, @dougbu - This is ready for another review. |
|
build is failing still. could you let us know when that's cleared up❓ |
What build are you referring to? |
| SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"] | ||
|
|
||
| # Install latest stable version of Python | ||
| RUN $apiUrl = 'https://api.nuget.org/v3-flatcontainer/python/index.json'; ` |
There was a problem hiding this comment.
It does feel a little strange the the SHELL is set to powershell here yet later on a direct powershell command is executed directly. It would be nice to have consistency within this Dockerfile.
I saw failures in a few of the jobs, including a required one, when looking at the list of checks. resolved now — either someone retried the jobs or my window was out of date |
mthalman
added
the
do-not-merge
|
I'll wait to merge this until next week when I'll have more availability to monitor the usage of these updates. |
| SHELL ["cmd", "/S", "/C"] | ||
| USER ContainerAdministrator | ||
| # Install latest stable version of Python | ||
| RUN powershell -Command "` |
There was a problem hiding this comment.
no big deal but this is easier to grok than the nanoserver approach using SHELL changes
|
I'm going to split these changes into separate PRs to have more focused issues being addressed. |
Removing the Helix Python script install from a handful of Dockerfiles. I want to roll this out to just these Dockerfiles for now to evaluate that things are working. I have run a test build with one of the images but I want to ensure things work in the wild across these platforms.
Contributes to #1333