Update Python version on Windows #1382
Conversation
|
This is getting a hadolint error: Caused by this line: What's notable is that this line hasn't been changed in this PR. It's the other changes in this PR that have now exposed this hadolint parsing issue: hadolint/hadolint#436 |
|
I fixed the linting issue by rewriting the logic to use PowerShell instead. |
|
not sure of the include capabilities that may be available here. is it possible to consolidate the many common pieces of these 4 DockerFiles❓ |
I would love that and have wanted it for a while now. I thought we had an issue for it, but I guess not. So I logged it: #1393 |
| Set-ItemProperty -Path 'HKLM:\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps\corerun.exe' -Value 2 -Name DumpType -Force ; ` | ||
| Set-ItemProperty -Path 'HKLM:\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps\corerun.exe' -Value 'C:\cores' -Name DumpFolder -Force ; ` | ||
| Set-ItemProperty -Path 'HKLM:\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps\corerun.exe' -Value 2 -Name DumpCount -Force | ||
| RUN setx /M PATH "%PATH%;C:\Program Files\PowerShell\;C:\Python;C:\python\scripts" && ` |
There was a problem hiding this comment.
shouldn't break anything (I hope) but suggest defining %VIRTUAL_ENV% first then including %VIRTUAL_ENV%\\Scripts in %PATH%
The Python version in the Windows Helix Dockerfiles is outdated. This ensures it gets the latest. This is a port of the changes that originally existed in #1336.