Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema #6596

Merged
merged 2 commits into from
Feb 9, 2025
Merged

Update schema #6596

merged 2 commits into from
Feb 9, 2025

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Nov 3, 2024

Description

Updating the schema to aspire-9.0. Just a rename of everything.

Fixes #6581

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

src/Shared/SchemaUtils.cs Outdated Show resolved Hide resolved
@danmoseley danmoseley added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Feb 2, 2025
@danmoseley danmoseley self-assigned this Feb 3, 2025
@danmoseley danmoseley marked this pull request as draft February 3, 2025 17:14
@danmoseley danmoseley force-pushed the mitchdenny/schema-9.0 branch from 0e83c66 to f6ee3c5 Compare February 7, 2025 20:10
@danmoseley danmoseley marked this pull request as ready for review February 7, 2025 20:11
@danmoseley
Copy link
Member

OK, schema is now fixed so that it passes the strict validation at schemastore on both 8.0 and latest manifests.

@danmoseley danmoseley changed the title Cut over to aspire-9.0 schema. Update schema Feb 7, 2025
@danmoseley danmoseley requested a review from eerhardt February 7, 2025 21:32
@danmoseley
Copy link
Member

@davidfowl easy one to signoff & merge

@davidfowl davidfowl merged commit a5c14f3 into main Feb 9, 2025
65 of 66 checks passed
@davidfowl davidfowl deleted the mitchdenny/schema-9.0 branch February 9, 2025 21:35
@davidfowl
Copy link
Member

@danmoseley @captainsafia made schema changes in 9.1. So, we'll need to do this again.

@captainsafia
Copy link
Member

@danmoseley @captainsafia made schema changes in 9.1. So, we'll need to do this again.

I assume you mean just a rename? I've already updated the schema with the changes needed for existing resources work.

@danmoseley
Copy link
Member

Yes, if you mean 4e1a0f2 then it's already in here and what I uploaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish 9.0 Aspire schema to schema store
5 participants