Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UX improvements to run-slice Makefile #1077

Closed
wants to merge 2 commits into from
Closed

Add UX improvements to run-slice Makefile #1077

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a919da
nohup on run-slice
alanorwick Sep 5, 2023
b01d18c
add conditional on run-slice for region and zone
alanorwick Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,16 @@ run-slice:
ifeq (,$(wildcard nodelogs))
mkdir nodelogs
endif
$(PRIME_CMD) >> $(PRIME_LOG_FILE) 2>&1 &
$(REGION_CMD) >> $(REGION_LOG_FILE) 2>&1 &
$(ZONE_CMD) >> $(ZONE_LOG_FILE) 2>&1 &
ifeq ($(filter $(REGION),0 1 2),)
$(error REGION must be 0, 1, or 2)
endif

ifeq ($(filter $(ZONE),0 1 2),)
$(error ZONE must be 0, 1, or 2)
endif
@nohup $(PRIME_CMD) >> $(PRIME_LOG_FILE) 2>&1 &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run slice is invalid, we need to remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how so?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even running a slice uses make run-all

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then why do we have 'run-all' as a make target? We should just have 'run', if there's no longer two run targets to differentiate between.

@nohup $(REGION_CMD) >> $(REGION_LOG_FILE) 2>&1 &
@nohup $(ZONE_CMD) >> $(ZONE_LOG_FILE) 2>&1 &

run-all:
ifeq (,$(wildcard nodelogs))
Expand Down
Loading