Add UX improvements to run-slice Makefile #1077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorwick
requested review from
wizeguyy,
kiltsonfire and
gameofpointers
as code owners
jdowning100
approved these changes
Sep 5, 2023
| $(PRIME_CMD) >> $(PRIME_LOG_FILE) 2>&1 & | ||
| $(REGION_CMD) >> $(REGION_LOG_FILE) 2>&1 & | ||
| $(ZONE_CMD) >> $(ZONE_LOG_FILE) 2>&1 & | ||
| @nohup $(PRIME_CMD) >> $(PRIME_LOG_FILE) 2>&1 & |
There was a problem hiding this comment.
run slice is invalid, we need to remove it
There was a problem hiding this comment.
Even running a slice uses make run-all
There was a problem hiding this comment.
Then why do we have 'run-all' as a make target? We should just have 'run', if there's no longer two run targets to differentiate between.
gameofpointers
requested changes
Sep 5, 2023
| $(PRIME_CMD) >> $(PRIME_LOG_FILE) 2>&1 & | ||
| $(REGION_CMD) >> $(REGION_LOG_FILE) 2>&1 & | ||
| $(ZONE_CMD) >> $(ZONE_LOG_FILE) 2>&1 & | ||
| @nohup $(PRIME_CMD) >> $(PRIME_LOG_FILE) 2>&1 & |
There was a problem hiding this comment.
Even running a slice uses make run-all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dominant-strategies/core-dev