-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EmailForward
fields
#57
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
003e1ae
Change: update test fixtures and adjust tests
ggalmazor fdd3335
Change: deprecate `from` and `to` in `EmailForward`
ggalmazor b03d2c5
Change: add CHANGELOG entries
ggalmazor 5d9ca99
Change: prevent clippy warnings in test
ggalmazor 227f231
Update src/dnsimple/domains_email_forwards.rs
ggalmazor 4bb851e
Update src/dnsimple/domains_email_forwards.rs
ggalmazor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,18 +19,19 @@ fn test_list_email_forwards() { | |
.unwrap(); | ||
let email_forwards_list = response.data.unwrap(); | ||
|
||
assert_eq!(2, email_forwards_list.len()); | ||
assert_eq!(1, email_forwards_list.len()); | ||
|
||
let email_forwards = email_forwards_list.first().unwrap(); | ||
|
||
assert_eq!(17702, email_forwards.id); | ||
assert_eq!(228963, email_forwards.domain_id); | ||
assert_eq!(24809, email_forwards.id); | ||
assert_eq!(235146, email_forwards.domain_id); | ||
assert_eq!(".*@a-domain.com", email_forwards.from); | ||
assert_eq!("[email protected]", email_forwards.to); | ||
assert_eq!("2016-02-04T13:59:29Z", email_forwards.created_at); | ||
assert_eq!("2016-02-04T13:59:29Z", email_forwards.updated_at); | ||
assert_eq!("2017-05-25T19:23:16Z", email_forwards.created_at); | ||
assert_eq!("2017-05-25T19:23:16Z", email_forwards.updated_at); | ||
} | ||
|
||
#[allow(deprecated)] | ||
#[test] | ||
fn test_create_email_forward() { | ||
let setup = setup_mock_for( | ||
|
@@ -63,6 +64,7 @@ fn test_create_email_forward() { | |
assert_eq!("[email protected]", record.to); | ||
} | ||
|
||
#[allow(deprecated)] | ||
#[test] | ||
fn test_get_email_forward() { | ||
let setup = setup_mock_for( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,16 @@ | ||
HTTP/1.1 200 OK | ||
Server: nginx | ||
Date: Thu, 04 Feb 2016 14:07:19 GMT | ||
Date: Fri, 17 May 2024 09:07:28 GMT | ||
Content-Type: application/json; charset=utf-8 | ||
Connection: keep-alive | ||
Status: 200 OK | ||
X-RateLimit-Limit: 4000 | ||
X-RateLimit-Remaining: 3993 | ||
X-RateLimit-Reset: 1454596043 | ||
ETag: W/"3f10aae0cf0f0b81bdb4f58786ee1750" | ||
X-RateLimit-Limit: 4800 | ||
X-RateLimit-Remaining: 4748 | ||
X-RateLimit-Reset: 1715936948 | ||
X-WORK-WITH-US: Love automation? So do we! https://dnsimple.com/jobs | ||
ETag: W/"a5eed9a071f03e10fc67001ccc647a94" | ||
Cache-Control: max-age=0, private, must-revalidate | ||
X-Request-Id: 6e3aa9d0-cb95-4186-93b0-630da372de86 | ||
X-Runtime: 0.026287 | ||
Strict-Transport-Security: max-age=31536000 | ||
X-Request-Id: e42df983-a8a5-4123-8c74-fb89ab934aba | ||
X-Runtime: 0.025456 | ||
Strict-Transport-Security: max-age=63072000 | ||
|
||
{"data":[{"id":17702,"domain_id":228963,"from":".*@a-domain.com","to":"[email protected]","created_at":"2016-02-04T13:59:29Z","updated_at":"2016-02-04T13:59:29Z"},{"id":17703,"domain_id":228963,"from":"john@a-domain.com","to":"john@example.com","created_at":"2016-02-04T14:07:13Z","updated_at":"2016-02-04T14:07:13Z"}],"pagination":{"current_page":1,"per_page":30,"total_entries":2,"total_pages":1}} | ||
{"data":[{"id":24809,"domain_id":235146,"alias_email":".*@a-domain.com","destination_email":"[email protected]","created_at":"2017-05-25T19:23:16Z","updated_at":"2017-05-25T19:23:16Z","from":".*@a-domain.com","to":"jane.smith@example.com"}],"pagination":{"current_page":1,"per_page":30,"total_entries":1,"total_pages":1}} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, the fixtures are updated to match the specs as they are applied across repos instead of updating the specs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. Let's remember this for next time, as all clients have been already updated with this change already 👍