Update EmailForward fields
#57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggalmazor
added
the
enhancement
DXTimer
reviewed
May 28, 2024
DXTimer
reviewed
May 28, 2024
DXTimer
reviewed
May 28, 2024
| @@ -19,18 +19,19 @@ fn test_list_email_forwards() { | |||
| .unwrap(); | |||
| let email_forwards_list = response.data.unwrap(); | |||
|
|
|||
| assert_eq!(2, email_forwards_list.len()); | |||
| assert_eq!(1, email_forwards_list.len()); | |||
There was a problem hiding this comment.
Usually, the fixtures are updated to match the specs as they are applied across repos instead of updating the specs.
There was a problem hiding this comment.
Fair point. Let's remember this for next time, as all clients have been already updated with this change already 👍
DXTimer
approved these changes
May 28, 2024
Co-authored-by: Ivan Bakalov <[email protected]>
Co-authored-by: Ivan Bakalov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dnsimple/dnsimple-developer#315 for reference
In this PR:
fromandtofields inEmailForward