-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EmailForward
fields
#389
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
65f735c
Change: add new attributes to EmailForward
ggalmazor 5be9448
Change: deprecate replaced fields in `EmailForward`
ggalmazor 8a7b144
Change: add CHANGELOG entries
ggalmazor cafad75
Change: update test fixture for `list` and adjust tests
ggalmazor 871c1ee
Change: use YARD deprecation comment
ggalmazor b32f3ea
Change: restore end-of-file whitespace
ggalmazor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -153,6 +153,8 @@ | |
expect(result.domain_id).to eq(235146) | ||
expect(result.from).to eq("[email protected]") | ||
expect(result.to).to eq("[email protected]") | ||
expect(result.alias_email).to eq("[email protected]") | ||
expect(result.destination_email).to eq("[email protected]") | ||
expect(result.created_at).to eq("2021-01-25T13:54:40Z") | ||
expect(result.updated_at).to eq("2021-01-25T13:54:40Z") | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ HTTP/1.1 201 Created | |
Server: nginx | ||
Date: Mon, 25 Jan 2021 13:54:40 GMT | ||
Content-Type: application/json; charset=utf-8 | ||
Transfer-Encoding: identity | ||
Connection: keep-alive | ||
X-RateLimit-Limit: 4800 | ||
X-RateLimit-Remaining: 4772 | ||
|
@@ -18,4 +19,4 @@ X-Permitted-Cross-Domain-Policies: none | |
Content-Security-Policy: frame-ancestors 'none' | ||
Strict-Transport-Security: max-age=31536000 | ||
|
||
{"data":{"id":41872,"domain_id":235146,"alias_email":"[email protected]","destination_email":"[email protected]","created_at":"2021-01-25T13:54:40Z","updated_at":"2021-01-25T13:54:40Z","from":"[email protected]","to":"[email protected]"}} | ||
{"data":{"id":41872,"domain_id":235146,"alias_email":"[email protected]","destination_email":"[email protected]","created_at":"2021-01-25T13:54:40Z","updated_at":"2021-01-25T13:54:40Z","from":"[email protected]","to":"[email protected]"}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ HTTP/1.1 200 OK | |
Server: nginx | ||
Date: Mon, 25 Jan 2021 13:56:24 GMT | ||
Content-Type: application/json; charset=utf-8 | ||
Transfer-Encoding: identity | ||
Connection: keep-alive | ||
X-RateLimit-Limit: 4800 | ||
X-RateLimit-Remaining: 4766 | ||
|
@@ -18,4 +19,4 @@ X-Permitted-Cross-Domain-Policies: none | |
Content-Security-Policy: frame-ancestors 'none' | ||
Strict-Transport-Security: max-age=31536000 | ||
|
||
{"data":{"id":41872,"domain_id":235146,"alias_email":"[email protected]","destination_email":"[email protected]","created_at":"2021-01-25T13:54:40Z","updated_at":"2021-01-25T13:54:40Z","from":"[email protected]","to":"[email protected]"}} | ||
{"data":{"id":41872,"domain_id":235146,"alias_email":"[email protected]","destination_email":"[email protected]","created_at":"2021-01-25T13:54:40Z","updated_at":"2021-01-25T13:54:40Z","from":"[email protected]","to":"[email protected]"}} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should use
@deprecated
https://rubydoc.info/gems/yard/file/docs/Tags.md#deprecatedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually use YARD in this codebase? I couldn't find it in the gemfile...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 we may not be linting, or generating docs from it, but I'd say that's the format we are using for all ruby repos... The
@param
and@return
are all YARD...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dnsimple-ruby/dnsimple.gemspec
Line 25 in be5da19