Update EmailForward fields
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test fixtures accordingly
jacegu
reviewed
May 17, 2024
lib/dnsimple/struct/email_forward.rb
Outdated
| @@ -11,15 +11,23 @@ class EmailForward < Base | |||
| attr_accessor :domain_id | |||
|
|
|||
| # @return [String] The "local part" of the originating email address. Anything to the left of the @ symbol. | |||
| # DEPRECATED: use `alias_email` instead | |||
There was a problem hiding this comment.
We probably should use @deprecated https://rubydoc.info/gems/yard/file/docs/Tags.md#deprecated
There was a problem hiding this comment.
Do we actually use YARD in this codebase? I couldn't find it in the gemfile...
There was a problem hiding this comment.
🤔 we may not be linting, or generating docs from it, but I'd say that's the format we are using for all ruby repos... The @param and @return are all YARD...
There was a problem hiding this comment.
dnsimple-ruby/dnsimple.gemspec
Line 25 in be5da19
dallasread
approved these changes
May 17, 2024
ggalmazor
force-pushed
the
change/update_email_forward_fields
branch
from
740668a to
b32f3ea
Compare
jacegu
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dnsimple/dnsimple-developer#315 for reference
In this PR:
alias_emailanddestination_emailfields toEmailForwardfromandtofields in `EmailForward