Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Code Review 조건 수정 #82

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix: Code Review 조건 수정 #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ permissions:

on:
pull_request:
types: [opened, reopened, synchronize]
types: [opened, reopened]

jobs:
test:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경 사항 분석:

  • 기존 "synchronize" 이벤트가 제거되었음
  • 현재 설정에서는 PR이 열리거나 다시 열릴 때만 작업이 실행됨

버그 위험:

  • 첫 번째 병합 과정 중 싱크 이벤트가 빠질 수 있음

개선 제안:

  • 실패한 풀 리퀘스트에 대한 처리 추가
  • 더 많은 이벤트 유형 (e.g., closed) 추가 고려

Expand Down