Fix: Code Review 조건 수정 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -6,7 +6,7 @@ permissions: | |||
|
|
|||
| on: | |||
| pull_request: | |||
| types: [opened, reopened, synchronize] | |||
| types: [opened, reopened] | |||
|
|
|||
| jobs: | |||
| test: | |||
There was a problem hiding this comment.
변경 사항 분석:
- 기존 "synchronize" 이벤트가 제거되었음
- 현재 설정에서는 PR이 열리거나 다시 열릴 때만 작업이 실행됨
버그 위험:
- 첫 번째 병합 과정 중 싱크 이벤트가 빠질 수 있음
개선 제안:
- 실패한 풀 리퀘스트에 대한 처리 추가
- 더 많은 이벤트 유형 (e.g., closed) 추가 고려
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
synchronize을 제거합니다. 커밋을 추가할 때마다 코드 리뷰가 달리는 것이 너무 과하다고 생각하여 제거하였습니다. 추가적인 코드리뷰가 필요할 경우 PR을 reopen하는 식으로 진행하면 됩니다.