Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new specsim api #3

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

NobleKennamer
Copy link
Collaborator

@NobleKennamer NobleKennamer commented May 10, 2016

This pull request is meant to update the code in bayez to work with the most recent specsim api.

NobleKennamer and others added 20 commits May 10, 2016 13:45
@NobleKennamer
Copy link
Collaborator Author

Both prepare_bayez and eval_bayez create simulator objects. When updating to the new specsim api the simulator object has been changed so that it is instantiated with the name of a config file or an actual config file. I think an additional command line argument like --config_name should be added to both prepare_bayez and and eval_bayez. Do you think we should use desi as the default? Also should we come up with some predefined list of what are acceptable config names (like with class names) or leave it more open with the possibility that an invalid config name would cause the simulator object to throw an exception upon creation?

@dkirkby
Copy link
Owner

dkirkby commented Jul 12, 2016

I agree about the new cmd-line config arg, for which either desi or test could be the default. Following the EAFP philosophy of python, I would try to use whatever config the user requests and catch a possible exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants