-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new specsim api #3
base: master
Are you sure you want to change the base?
Conversation
…rt and stop of pixels
…leaner way of doing it
…w questions in regards to api change
…he BayezExample notebook for more details
…r update_in to deal with now
…stimate.run(..) on iteration 39369
…date except for desi_bayez
Both prepare_bayez and eval_bayez create simulator objects. When updating to the new specsim api the simulator object has been changed so that it is instantiated with the name of a config file or an actual config file. I think an additional command line argument like --config_name should be added to both prepare_bayez and and eval_bayez. Do you think we should use desi as the default? Also should we come up with some predefined list of what are acceptable config names (like with class names) or leave it more open with the possibility that an invalid config name would cause the simulator object to throw an exception upon creation? |
I agree about the new cmd-line config arg, for which either |
This pull request is meant to update the code in bayez to work with the most recent specsim api.