Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix commitWithin for JSON updates w/o boost #421

Merged
merged 1 commit into from
Sep 4, 2023

Commits on Sep 1, 2023

  1. fix commitWithin for JSON updates w/o boost or fieldUpdates

     - 3.9.0 included changes such that the `commitWithin` arg
       to the `add` method was no longer used unless either
       `boost` or `fieldValues` was provided, since the new logic
       to support sending JSON docs doesn't use `commitWithin`
     - these changes add `commit_within` to the `Solr._update`
       method and modify that method to include `commitWithin`
       as a query parameter if it is provided, which is simpler
       than needing different logic for the two cases of XML
       and JSON docs
     - also added a test case for `commitWithin`, which wasn't
       tested previously
    Calvin Smith committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    9f1a7f3 View commit details
    Browse the repository at this point in the history