fix commitWithin for JSON updates w/o boost
#421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 3.9.0 included changes such that the `commitWithin` arg to the `add` method was no longer used unless either `boost` or `fieldValues` was provided, since the new logic to support sending JSON docs doesn't use `commitWithin` - these changes add `commit_within` to the `Solr._update` method and modify that method to include `commitWithin` as a query parameter if it is provided, which is simpler than needing different logic for the two cases of XML and JSON docs - also added a test case for `commitWithin`, which wasn't tested previously
acdha
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commitWithinto theSolr._updatemethodm and modify that method to includecommitWithinas a query parameter if it is providedcommitWithininside theaddXML messages, so it's handled the same for botth XML and JSONcommitWithin, which wasn't tested previouslyaddcalls without aboostorfieldUpdatesvalue no longer honoring thecommitWithinif it was provided