-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reduce number of thumbnails created for admin, avoid admin thumbnails for svg files #1490
Merged
vinitkumar
merged 24 commits into
django-cms:master
from
fsbraun:fix/no-admin-svg-thumbnails
Aug 22, 2024
Merged
fix: Reduce number of thumbnails created for admin, avoid admin thumbnails for svg files #1490
vinitkumar
merged 24 commits into
django-cms:master
from
fsbraun:fix/no-admin-svg-thumbnails
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinitkumar
reviewed
Aug 22, 2024
vinitkumar
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor feedback. Otherwise, this looks excellent. Great work as always @fsbraun :)
vinitkumar
approved these changes
Aug 22, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Over the years, several thumbnail file sizes for the filer admin have accumulated:
This PR reduces the thumbnail sizes to two
FILER_TABLE_ICON_SIZE = 40
for table listings plus twice the value for detail viewsFILER_THUMBNAIL_ICON_SIZE = 120
for the thumbnail viewNo thumbnails are generated for SVG files shown in the admin.
This PR fixes #1489 and reduces the amount of storage used up for thumbnails used by the filer admin interface.
Currently, the icon sizes are also hard-coded into the css. The next step will be to make them html attributes and have dynamic css that adjusts to the attributes.
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.