-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: editing buttons missing in admin when file present #1511
Conversation
Reviewer's Guide by SourceryThis PR fixes a UI issue in the admin interface by adding the 'image-preview-container' class to the file preview element, which enables the proper application of existing SASS styling rules for editing buttons. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pajowu - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
f4c9bb7
to
9474997
Compare
@fsbraun yes, that fixed it as well. I updated the commit accordingly. Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙏
Description
This PR adds the
image-preview-container
to the admin file preview. This is needed so that the sass-rules from_image-info.scss
gets applied. This fixes the issue described in #1499Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.
I did not do the last item, as the slack-channel no longer exists :)
Summary by Sourcery
Bug Fixes: