Change radar_enable_seat_icons Setting to List

[mrschick]

ref #209 (comment)
follow-up to #223

• Improves on the new enable_seat_icons setting by making it a list with 3 options:
  • Never show
  • Only show for group members in the same vehicle
  • Always show (default)

[mrschick]

Maybe a fourth option could be to show only for units within LOS 🤔

Though it probably makes sense to move some of the LOS checking code to its own function for that

diwako_dui/addons/radar/functions/fnc_displayUnitOnCompass.sqf

Line 104 in e092e63

private _vis = [vehicle _unit, "VIEW"] checkVisibility [eyePos _player, AGLToASL (_unit modelToWorldVisual (_unit selectionPosition "Spine2"))];

[diwako]

Maybe a fourth option could be to show only for units within LOS 🤔

Though it probably makes sense to move some of the LOS checking code to its own function for that

diwako_dui/addons/radar/functions/fnc_displayUnitOnCompass.sqf

Line 104 in e092e63

private _vis = [vehicle _unit, "VIEW"] checkVisibility [eyePos _player, AGLToASL (_unit modelToWorldVisual (_unit selectionPosition "Spine2"))];

I would say to keep it simple, more LOS checks are not needed. It might make sense in a cramped vehicle like a BMP, but LOS checks within vehicles are kind of scuffed.

[mrschick]

Fully agree, I only meant LOS checks from foot to buddies in a vehicle, or at least to the vehicle itself.

[mrschick]

Rethinking it, the current implementation should be fine.

[diwako]

ready for merge?

[mrschick]

Fine by me 👍🏻