Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "rc/results-title-response" #1444

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

Jtang-1
Copy link
Contributor

@Jtang-1 Jtang-1 commented Aug 15, 2023

Product Description

Technical Summary

related to cc-core PR: dimagi/commcare-core#1320

Safety Assurance

Safety story

Automated test coverage

QA Plan

Special deploy instructions

merge before dimagi/commcare-core#1320

Rollback instructions

if reverted, also revert dimagi/commcare-core#1320

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1444 (29ef01e) into master (0549eb7) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1444      +/-   ##
============================================
- Coverage     69.68%   69.66%   -0.02%     
+ Complexity     1920     1918       -2     
============================================
  Files           247      247              
  Lines          7533     7529       -4     
  Branches        674      674              
============================================
- Hits           5249     5245       -4     
  Misses         2020     2020              
  Partials        264      264              
Files Changed Coverage Δ
...care/formplayer/beans/menus/QueryResponseBean.java 97.77% <ø> (-0.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jtang-1 Jtang-1 marked this pull request as ready for review August 15, 2023 23:43
Copy link
Contributor

@shubham1g5 shubham1g5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though we should update the submodule libs/commcare in this branch to point to latest head of formplayer branch after merging the corresponding core PR

@Jtang-1 Jtang-1 merged commit 3c702f7 into master Aug 16, 2023
4 checks passed
@Jtang-1 Jtang-1 deleted the revert-1425-rc/results-title-response branch August 16, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants