Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Rc/sccs subtitle" #1320

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Revert "Rc/sccs subtitle" #1320

merged 1 commit into from
Aug 16, 2023

Conversation

Jtang-1
Copy link
Contributor

@Jtang-1 Jtang-1 commented Aug 15, 2023

Product Description

Reverts #1307 (comment)

Technical Summary

On HQ side, dimagi/commcare-hq#33359 reverts dimagi/commcare-hq#33261 and removes the need for a results-title node.

HQ Ticket: https://dimagi-dev.atlassian.net/browse/USH-3539
Relates to formplayer PR: dimagi/formplayer#1444

Safety Assurance

For existing builds with suites that contain the results-title node, they will just be ignored when parsed

Safety story

Automated test coverage

removes test that covers result-title

QA Plan

No QA

Special deploy instructions

Must be deployed with dimagi/formplayer#1444 (reversion of dimagi/formplayer#1425)

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

@Jtang-1
Copy link
Contributor Author

Jtang-1 commented Aug 16, 2023

duplicate this PR

@Jtang-1 Jtang-1 merged commit ff31434 into formplayer Aug 16, 2023
2 checks passed
@Jtang-1 Jtang-1 deleted the revert-1307-rc/sccs-subtitle branch August 16, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants