Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract signature suites to separate repos. #126

Merged
merged 24 commits into from
Mar 18, 2021
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
05de1fc
Remove legacy suites, owner and creator logic.
dmitrizagidulin Aug 9, 2020
3238ae5
Remove legacy PublicKeyProofPurpose.
dmitrizagidulin Aug 9, 2020
ded74d6
No longer export crypto-ld classes.
dmitrizagidulin Aug 9, 2020
e31dfc3
Use crypto-ld v4.
dmitrizagidulin Aug 9, 2020
8d491a6
Remove extracted suites.
dmitrizagidulin Aug 10, 2020
2de6630
Reset tests, hook up eslint to test script.
dmitrizagidulin Aug 10, 2020
366bdbd
Update karma config, refactor, remove unneeded util code.
dmitrizagidulin Mar 17, 2021
d126654
Fix test matrix.
dmitrizagidulin Mar 17, 2021
aaecfa2
Update README for new version.
dmitrizagidulin Mar 18, 2021
9fba76a
Update CHANGELOG, drop unneeded dependency.
dmitrizagidulin Mar 18, 2021
b054ac4
Temporarily disable jsdoc linting.
dmitrizagidulin Mar 18, 2021
805d2af
Update CHANGELOG.md (formatting)
dmitrizagidulin Mar 18, 2021
add71ed
Remove stray .npmrc.
dmitrizagidulin Mar 18, 2021
13a6895
Remove compactProof code from ProofSet.add().
dmitrizagidulin Mar 18, 2021
3fbc028
Remove compactProof param everywhere.
dmitrizagidulin Mar 18, 2021
abbb731
Remove _getTypeInfo() - not used anymore.
dmitrizagidulin Mar 18, 2021
2a52c3a
Remove proofProperty internal variable.
dmitrizagidulin Mar 18, 2021
e97f755
Remove deleting proof context, reformat.
dmitrizagidulin Mar 18, 2021
e7903b3
Update README.md (edit badges)
dmitrizagidulin Mar 18, 2021
96d9753
Update to latest jsonld lib.
dmitrizagidulin Mar 18, 2021
9c3be07
Do not insert security context into proof.
dmitrizagidulin Mar 18, 2021
e6f3688
Add document's context or security context to proof in canonize.
dmitrizagidulin Mar 18, 2021
64804ae
Remove bae64url dependency.
davidlehn Mar 18, 2021
138ed61
Remove node-forge and env script.
dmitrizagidulin Mar 18, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,22 @@
/*!
* Copyright (c) 2021 Digital Bazaar, Inc. All rights reserved.
*/
module.exports = {
root: true,
extends: [
'eslint-config-digitalbazaar',
// 'eslint-config-digitalbazaar/jsdoc'
gannan08 marked this conversation as resolved.
Show resolved Hide resolved
],
env: {
commonjs: true,
node: true
},
extends: ['eslint-config-digitalbazaar']
parserOptions: {
// this is required for dynamic import()
ecmaVersion: 2020
},
ignorePatterns: ['node_modules', 'dist'],
rules: {
'jsdoc/check-examples': 0,
'jsdoc/require-description-complete-sentence': 0
}
};
94 changes: 45 additions & 49 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,75 +3,71 @@ name: Node.js CI
on: [push]

jobs:
test-node:
lint:
runs-on: ubuntu-latest
timeout-minutes: 10
strategy:
matrix:
node-version: [10.x, 12.x, 14.x]
node-version: [14.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: Install
run: npm install
- name: Run test with Node.js ${{ matrix.node-version }}
run: npm run test-node
test-karma:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- name: Run eslint
run: npm run lint
test-node:
runs-on: ubuntu-latest
needs: [lint]
timeout-minutes: 10
strategy:
matrix:
node-version: [14.x]
bundler: [webpack, browserify]
node-version: [12.x, 14.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: Install
run: npm install
- name: Run karma tests
env:
BUNDLER: ${{ matrix.bundler }}
run: npm run test-karma
lint:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- name: Run test with Node.js ${{ matrix.node-version }}
run: npm run test-node
test-karma:
runs-on: ubuntu-latest
needs: [lint]
timeout-minutes: 10
strategy:
matrix:
node-version: [14.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- name: Run eslint
run: npm run lint
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- name: Run karma tests
run: npm run test-karma
coverage:
needs: [test-node, test-karma]
runs-on: ubuntu-latest
timeout-minutes: 10
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: Install
run: npm install
- name: Generate coverage report
run: npm run coverage-ci
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
with:
file: ./coverage/lcov.info
fail_ci_if_error: true
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- name: Generate coverage report
run: npm run coverage-ci
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
with:
file: ./coverage/lcov.info
fail_ci_if_error: true
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
package-lock=false
dmitrizagidulin marked this conversation as resolved.
Show resolved Hide resolved
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
# jsonld-signatures ChangeLog

## 8.0.0 -

### Changed
- **BREAKING**: Remove `PublicKeyProofPurpose`.
- **BREAKING**: Remove `GraphSignature2012` suite.
- **BREAKING**: Remove `LinkedDataSignature2015` suite.
- **BREAKING**: Drop support for deprecated `owner` proof property.
- **BREAKING**: Drop support for deprecated `creator` proof property.
- **BREAKING**: Remove bundled signature suites; all moved to external repos:
- `JwsLinkedDataSignature` suite moved to https://github.com/digitalbazaar/jws-linked-data-signature
- `RsaSignature2018` suite moved to https://github.com/digitalbazaar/rsa-signature-2018
- `Ed25519Signature2018` suite moved to https://github.com/digitalbazaar/ed25519-signature-2018
dmitrizagidulin marked this conversation as resolved.
Show resolved Hide resolved
- **BREAKING**: Drop support for Node.js v10 (it's leaving LTS).

## 7.0.0 - 2021-02-11

### Changed
Expand Down
Loading