Extract signature suites to separate repos. #126
Conversation
dmitrizagidulin
requested review from
davidlehn,
dlongley,
mattcollier and
gannan08
Co-authored-by: David I. Lehn <[email protected]>
| @@ -60,217 +81,67 @@ increase security by using a custom `documentLoader` that is similarly strict | |||
| and will only load a subset of documents that is constrained by some technical, | |||
| security, or business rules. | |||
|
|
|||
| Install with npm: | |||
There was a problem hiding this comment.
Why are the common case npm install instructions gone in favor of only development checkout instructions? I highly suggest we add back the common case here so people can easily see what npm package to use.
There was a problem hiding this comment.
Reading more... this is because it's suggested to use the other suites vs this directly? I think the text ordering may be a bit confusing in that regard.
There was a problem hiding this comment.
Yeah, because most devs won't be installing jsigs directly. (hopefully).
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
===========================================
- Coverage 79.93% 22.05% -57.88%
===========================================
Files 23 18 -5
Lines 598 331 -267
===========================================
- Hits 478 73 -405
- Misses 120 258 +138
Continue to review full report at Codecov.
|
Also remove legacy suites and properties.
Addresses issue #105.