Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw exception instead of returning false, if gcm tag validation evaluates to invalid. #979

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

throw exception instead of returning false, if gcm tag validation evaluates to invalid. #979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/cipherModes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,6 +731,8 @@ modes.gcm.prototype.decrypt = function(input, output, finish) {
}
};

var unauthenticException = new Error('Error: MAC Mispatch. Content and/or MAC has been tempared with');

modes.gcm.prototype.afterFinish = function(output, options) {
var rval = true;

Expand Down Expand Up @@ -760,7 +762,7 @@ modes.gcm.prototype.afterFinish = function(output, options) {

// check authentication tag
if(options.decrypt && this.tag.bytes() !== this._tag) {
rval = false;
throw unauthenticException;
}

return rval;
Expand Down