Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw exception instead of returning false, if gcm tag validation evaluates to invalid. #979

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johanna-herrmann
Copy link

BREAKING CHANGE!
Major update.

If aes gcm tag validation evaluates to invalid,
an error / exception should be thrown,
following the gcm specification:
https://csrc.nist.rip/groups/ST/toolkit/BCM/documents/proposedmodes/gcm/gcm-spec.pdf

Otherwise the user of this library has to check the validation which could be forgotten.

Libraries always should do all checks they can do,
so library using developers can just use it.

BREAKING CHANGE!
Major update.

If aes gcm tag validation evaluates to invalid,
an error / exception should be thrown,
following the gcm specification:
https://csrc.nist.rip/groups/ST/toolkit/BCM/documents/proposedmodes/gcm/gcm-spec.pdf

Otherwise the user of this library has to check the validation which could be forgotten.

Libraries always should do all checks they can do,
so library using developers can just use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant