[UP-84] perform upgrade verification in softFetchInterface #20110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
approved these changes
Oct 17, 2024
paulbrauner-da
added a commit
that referenced
this pull request
Oct 18, 2024
…20110) * add failing tests for signatories and observers * add ensure clause dynamic exercise test * add dynamic exercise/fetch tests for changed keys * fix bug
paulbrauner-da
added a commit
that referenced
this pull request
Oct 21, 2024
…20110) * add failing tests for signatories and observers * add ensure clause dynamic exercise test * add dynamic exercise/fetch tests for changed keys * fix bug
paulbrauner-da
changed the title
paulbrauner-da
added a commit
that referenced
this pull request
Oct 23, 2024
…in softFetchInterface (#20126) * fix local contract upgrade (#20035) * test for local contract upgrade * fix fetchAny for local contracts * add ex and ex by key tests * add local contract tests to ExceptionsTest * add fetch by key test * Add tests for dynamic exercise. * Fix up-84: softFetchInterface does not perform upgrade verification (#20110) (#20127) * add failing tests for signatories and observers * add ensure clause dynamic exercise test * add dynamic exercise/fetch tests for changed keys * fix bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #20099 for 2.x
Before this PR, if an upgrade changes the signatory, observer or key value of a contract, it won't be detected when the upgrade takes place as part of a dynamic fetch or exercise. This PR adds tests for these cases and fixes the issue.